scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch.json - Issue 2480193002: Stop to use contextmanager for goma.build_with_goma

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch.json

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)

Patch Set: update Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/goma/api.py ('K') | « scripts/slave/recipes/chromium_afl.expected/full_chromium_fyi_Afl_Upload_Linux_ASan.json ('k') | scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch_Builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch.json

diff --git a/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch.json b/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch.json

index 19ea4ddc02d7848b7e1af4b80470ded6901e8c78..00d6fa406a39a40a6be3074ea532111fbeb523e3 100644

--- a/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch.json

+++ b/scripts/slave/recipes/chromium_codesearch.expected/full_ChromiumOS_Codesearch.json

@@ -449,9 +449,9 @@

"[SLAVE_BUILD]/src/out/Debug",

"-k",

"0",

+ "all",

"-j",

- "50",

- "all"

+ "50"

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

@@ -521,7 +521,7 @@

"--ninja-log-compiler",

"goma-clang",

"--ninja-log-command",

- "['RECIPE_PACKAGE_REPO[depot_tools]/ninja', '-w', 'dupbuild=err', '-C', '[SLAVE_BUILD]/src/out/Debug', '-k', '0', '-j', 50, 'all']",

+ "['RECIPE_PACKAGE_REPO[depot_tools]/ninja', '-w', 'dupbuild=err', '-C', '[SLAVE_BUILD]/src/out/Debug', '-k', '0', 'all', '-j', 50]",

"--ninja-log-exit-status",

"0",

"--buildbot-buildername",