scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json - Issue 2480193002: Stop to use contextmanager for goma.build_with_goma

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)

Patch Set: 1 -> true Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium/api.py ('k') | scripts/slave/recipe_modules/goma/api.py » ('j') | scripts/slave/recipe_modules/goma/example.expected/linux_goma_disabled.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

diff --git a/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json b/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

index 6820748dfdfed43e458d9f7d466954f614aa2277..64e71a4cc76989539d011be804bbd0caed954db2 100644

--- a/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

+++ b/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

@@ -355,7 +355,6 @@

"GOMA_ALLOWED_NETWORK_ERROR_DURATION": "1800",

"GOMA_CACHE_DIR": "[GOMA_CACHE]",

"GOMA_DEPS_CACHE_FILE": "Win_Builder.gomadeps",

- "GOMA_DISABLED": "true",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json"

"name": "update windows env"