scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json - Issue 2480193002: Stop to use contextmanager for goma.build_with_goma

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)

Patch Set: fix pylint Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module.json ('k') | scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_with_goma_module.json » ('j') | scripts/slave/recipe_modules/goma/api.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

diff --git a/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json b/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

index 6820748dfdfed43e458d9f7d466954f614aa2277..ef01fc25c7607235ca1f8218240d85dd68402eb7 100644

--- a/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

+++ b/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module_goma_disabled_win.json

@@ -252,33 +252,6 @@

"name": "generate_build_files"

{

- "cmd": [

- "python",

- "-u",

- "\nimport multiprocessing\nimport sys\n\njob_limit = 200\nif sys.platform.startswith('linux'):\n # Use 80 for linux not to load goma backend.\n job_limit = 80\n\ntry:\n jobs = min(job_limit, multiprocessing.cpu_count() * 10)\nexcept NotImplementedError:\n jobs = 50\n\nprint jobs\n"

- ],

- "name": "calculate the number of recommended jobs",

- "stdout": "/path/to/tmp/",

- "~followup_annotations": [

- "@@@STEP_LOG_LINE@python.inline@@@@",

- "@@@STEP_LOG_LINE@python.inline@import multiprocessing@@@",

- "@@@STEP_LOG_LINE@python.inline@import sys@@@",

- "@@@STEP_LOG_LINE@python.inline@@@@",

- "@@@STEP_LOG_LINE@python.inline@job_limit = 200@@@",

- "@@@STEP_LOG_LINE@python.inline@if sys.platform.startswith('linux'):@@@",

- "@@@STEP_LOG_LINE@python.inline@ # Use 80 for linux not to load goma backend.@@@",

- "@@@STEP_LOG_LINE@python.inline@ job_limit = 80@@@",

- "@@@STEP_LOG_LINE@python.inline@@@@",

- "@@@STEP_LOG_LINE@python.inline@try:@@@",

- "@@@STEP_LOG_LINE@python.inline@ jobs = min(job_limit, multiprocessing.cpu_count() * 10)@@@",

- "@@@STEP_LOG_LINE@python.inline@except NotImplementedError:@@@",

- "@@@STEP_LOG_LINE@python.inline@ jobs = 50@@@",

- "@@@STEP_LOG_LINE@python.inline@@@@",

- "@@@STEP_LOG_LINE@python.inline@print jobs@@@",

- "@@@STEP_LOG_END@python.inline@@@"

- ]

- },

- {

"cmd": [],

"name": "preprocess_for_goma"