Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)
Patch Set: fix pylint Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json
diff --git a/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json b/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json
index 5fe3a1f255c881c68e2f6a195b50ac93ff82a311..4d2ce8f302c23f647270160493d42bed40701c8c 100644
--- a/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json
+++ b/scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json
@@ -191,10 +191,10 @@
{
"cmd": [
"ninja",
- "-C",
- "[SLAVE_BUILD]/pdfium/out/release_xfa_v8",
"-j",
- "50"
+ "50",
+ "-C",
+ "[SLAVE_BUILD]/pdfium/out/release_xfa_v8"
],
"name": "compile with ninja"
},
@@ -261,7 +261,7 @@
"--ninja-log-compiler",
"unknown",
"--ninja-log-command",
- "['ninja', '-C', Path('checkout', 'out','release_xfa_v8'), '-j', 50]",
+ "['ninja', '-j', 50, '-C', Path('checkout', 'out','release_xfa_v8')]",
"--ninja-log-exit-status",
"0",
"--buildbot-buildername",

Powered by Google App Engine
This is Rietveld 408576698