Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2910)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/pdfium.expected/mac_skia.json

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)
Patch Set: fix pylint Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/goma/api.py ('K') | « scripts/slave/recipes/pdfium.expected/mac_no_v8.json ('k') | scripts/slave/recipes/pdfium.expected/mac_xfa.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/pdfium.expected/mac_skia.json
diff --git a/scripts/slave/recipes/pdfium.expected/mac_skia.json b/scripts/slave/recipes/pdfium.expected/mac_skia.json
index 9f69de2e1297685d134c41542354842dfe79f293..af21eb89f3f1114eb238d4a1b8011afba9ac7dad 100644
--- a/scripts/slave/recipes/pdfium.expected/mac_skia.json
+++ b/scripts/slave/recipes/pdfium.expected/mac_skia.json
@@ -191,10 +191,10 @@
{
"cmd": [
"ninja",
- "-C",
- "[SLAVE_BUILD]/pdfium/out/debug_skia_xfa_v8",
"-j",
- "50"
+ "50",
+ "-C",
+ "[SLAVE_BUILD]/pdfium/out/debug_skia_xfa_v8"
],
"name": "compile with ninja"
},
@@ -261,7 +261,7 @@
"--ninja-log-compiler",
"unknown",
"--ninja-log-command",
- "['ninja', '-C', Path('checkout', 'out','debug_skia_xfa_v8'), '-j', 50]",
+ "['ninja', '-j', 50, '-C', Path('checkout', 'out','debug_skia_xfa_v8')]",
"--ninja-log-exit-status",
"0",
"--buildbot-buildername",
« scripts/slave/recipe_modules/goma/api.py ('K') | « scripts/slave/recipes/pdfium.expected/mac_no_v8.json ('k') | scripts/slave/recipes/pdfium.expected/mac_xfa.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698