Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: scripts/slave/recipes/chromium_codesearch.py

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)
Patch Set: fix pylint Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_codesearch.py
diff --git a/scripts/slave/recipes/chromium_codesearch.py b/scripts/slave/recipes/chromium_codesearch.py
index df08a706ec8a915cb8e035fdcf2671783a1d93d1..287b4f705025c8292feade6c6672c246d21aa469 100644
--- a/scripts/slave/recipes/chromium_codesearch.py
+++ b/scripts/slave/recipes/chromium_codesearch.py
@@ -110,15 +110,14 @@ def GenerateCompilationDatabase(api, debug_path, targets, platform):
# Add the parameters for creating the compilation database.
command += ['-t', 'compdb', 'cc', 'cxx', 'objc', 'objcxx']
- command += ['-j', api.goma.recommended_goma_jobs]
-
with api.goma.build_with_goma(
ninja_log_outdir=debug_path,
- ninja_log_command=command,
- ninja_log_compiler='goma'):
+ ninja_command=command,
+ ninja_log_compiler='goma') as (env_update, ninja_command):
return api.step('generate compilation database for %s' % platform,
- command,
- stdout=api.raw_io.output())
+ ninja_command,
+ stdout=api.raw_io.output(),
+ env=env_update)
def RunSteps(api):

Powered by Google App Engine
This is Rietveld 408576698