Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/pdfium.py

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)
Patch Set: fix pylint Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/goma/api.py ('K') | « scripts/slave/recipes/nacl/sdk.expected/basic.json ('k') | scripts/slave/recipes/pdfium.expected/android.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/pdfium.py
diff --git a/scripts/slave/recipes/pdfium.py b/scripts/slave/recipes/pdfium.py
index 0eb807f4eae634e4fd5f608d031b48df6b95516e..438c0fbc38f9203703e891b647f2dad88fc88305 100644
--- a/scripts/slave/recipes/pdfium.py
+++ b/scripts/slave/recipes/pdfium.py
@@ -99,8 +99,8 @@ def _BuildSteps(api, clang, out_dir):
with api.goma.build_with_goma(
ninja_log_outdir=debug_path,
ninja_log_compiler='clang' if clang else 'unknown',
- ninja_log_command=ninja_cmd):
- api.step('compile with ninja', ninja_cmd)
+ ninja_command=ninja_cmd) as (_, updated_ninja_cmd):
+ api.step('compile with ninja', updated_ninja_cmd)
def _RunTests(api, memory_tool, v8, out_dir):
« scripts/slave/recipe_modules/goma/api.py ('K') | « scripts/slave/recipes/nacl/sdk.expected/basic.json ('k') | scripts/slave/recipes/pdfium.expected/android.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698