Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: scripts/slave/recipes/pdfium.py

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)
Patch Set: fix pylint Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'depot_tools/gclient', 6 'depot_tools/gclient',
7 'depot_tools/bot_update', 7 'depot_tools/bot_update',
8 'goma', 8 'goma',
9 'recipe_engine/path', 9 'recipe_engine/path',
10 'recipe_engine/platform', 10 'recipe_engine/platform',
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 92
93 def _BuildSteps(api, clang, out_dir): 93 def _BuildSteps(api, clang, out_dir):
94 # Build sample file using Ninja 94 # Build sample file using Ninja
95 debug_path = api.path['checkout'].join('out', out_dir) 95 debug_path = api.path['checkout'].join('out', out_dir)
96 ninja_cmd = ['ninja', '-C', debug_path, 96 ninja_cmd = ['ninja', '-C', debug_path,
97 '-j', api.goma.recommended_goma_jobs] 97 '-j', api.goma.recommended_goma_jobs]
98 98
99 with api.goma.build_with_goma( 99 with api.goma.build_with_goma(
100 ninja_log_outdir=debug_path, 100 ninja_log_outdir=debug_path,
101 ninja_log_compiler='clang' if clang else 'unknown', 101 ninja_log_compiler='clang' if clang else 'unknown',
102 ninja_log_command=ninja_cmd): 102 ninja_command=ninja_cmd) as (_, updated_ninja_cmd):
103 api.step('compile with ninja', ninja_cmd) 103 api.step('compile with ninja', updated_ninja_cmd)
104 104
105 105
106 def _RunTests(api, memory_tool, v8, out_dir): 106 def _RunTests(api, memory_tool, v8, out_dir):
107 env = {} 107 env = {}
108 if memory_tool == 'asan': 108 if memory_tool == 'asan':
109 options = ['detect_leaks=1', 109 options = ['detect_leaks=1',
110 'allocator_may_return_null=1', 110 'allocator_may_return_null=1',
111 'symbolize=1', 111 'symbolize=1',
112 'external_symbolizer_path=' 112 'external_symbolizer_path='
113 'third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer'] 113 'third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer']
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 363
364 yield ( 364 yield (
365 api.test('android') + 365 api.test('android') +
366 api.platform('linux', 64) + 366 api.platform('linux', 64) +
367 api.properties(mastername='client.pdfium', 367 api.properties(mastername='client.pdfium',
368 buildername='android', 368 buildername='android',
369 slavename='test_slave', 369 slavename='test_slave',
370 target_os='android', 370 target_os='android',
371 skip_test=True) 371 skip_test=True)
372 ) 372 )
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698