Add a TLD whitelist for Google Search URLs.

Add a TLD whitelist for Google Search URLs.

Also send an extra to Instant Apps when we have verified a page is SERP.
BUG=656193, 658914
Committed: https://crrev.com/b5b2836070cadd1bea1d786593efeeb45893c342
Cr-Commit-Position: refs/heads/master@{#431670}

[Maria, 2016-11-07 21:52:43]

mariakhomenko@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Maria, 2016-11-07 22:14:30]

Description was changed from

==========
Add a TLD whitelist for Google Search URLs.

Also send an extra to Instant Apps when we have verified a page is SERP.
BUG=656193
==========

to

==========
Add a TLD whitelist for Google Search URLs.

Also send an extra to Instant Apps when we have verified a page is SERP.
BUG=656193,658914
==========

[Ted C, 2016-11-08 01:03:39]

lgtm

[Maria, 2016-11-11 21:18:24]

The CQ bit was checked by mariakhomenko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 21:18:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ted C, 2016-11-11 21:43:51]

On 2016/11/08 01:03:39, Ted C wrote:
> lgtm

still lgtm

[commit-bot: I haz the power, 2016-11-11 21:54:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 21:54:26]

Dry run: This issue passed the CQ dry run.

[Maria, 2016-11-11 22:11:47]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2016-11-11 22:12:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 22:28:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-11 22:44:29]

Description was changed from

==========
Add a TLD whitelist for Google Search URLs.

Also send an extra to Instant Apps when we have verified a page is SERP.
BUG=656193,658914
==========

to

==========
Add a TLD whitelist for Google Search URLs.

Also send an extra to Instant Apps when we have verified a page is SERP.
BUG=656193,658914

Committed: https://crrev.com/b5b2836070cadd1bea1d786593efeeb45893c342
Cr-Commit-Position: refs/heads/master@{#431670}
==========

[commit-bot: I haz the power, 2016-11-11 22:44:30]

Patchset 4 (id:??) landed as
https://crrev.com/b5b2836070cadd1bea1d786593efeeb45893c342
Cr-Commit-Position: refs/heads/master@{#431670}

[battre (please use the other), 2016-11-11 22:54:10]

battre@google.com changed reviewers:
+ battre@google.com

[battre (please use the other), 2016-11-11 22:54:10]

https://codereview.chromium.org/2480153003/diff/60001/chrome/browser/android/...
File chrome/browser/android/url_utilities.cc (right):

https://codereview.chromium.org/2480153003/diff/60001/chrome/browser/android/...
chrome/browser/android/url_utilities.cc:29: // TODO(mariakhomenko): figure out
how to keep this list updated.
IsCanonicalHostGoogleHostname in components/google/core/browser/google_util.cc
could also benefit from this.

https://codereview.chromium.org/2480153003/diff/60001/chrome/browser/android/...
chrome/browser/android/url_utilities.cc:144: bool is_search =
google_util::IsGoogleSearchUrl(gurl);
Wouldn't it make sense to move the logic into this?

[Maria, 2016-11-11 22:57:13]

On 2016/11/11 22:54:10, battre (please use the other) wrote:
>
https://codereview.chromium.org/2480153003/diff/60001/chrome/browser/android/...
> File chrome/browser/android/url_utilities.cc (right):
> 
>
https://codereview.chromium.org/2480153003/diff/60001/chrome/browser/android/...
> chrome/browser/android/url_utilities.cc:29: // TODO(mariakhomenko): figure out
> how to keep this list updated.
> IsCanonicalHostGoogleHostname in components/google/core/browser/google_util.cc
> could also benefit from this.
> 
>
https://codereview.chromium.org/2480153003/diff/60001/chrome/browser/android/...
> chrome/browser/android/url_utilities.cc:144: bool is_search =
> google_util::IsGoogleSearchUrl(gurl);
> Wouldn't it make sense to move the logic into this?

Yes, I will work on that next. I wanted the logic to be in android-specific
place because I am merging it into branch, so this limits the scope of any
potential regressions. I will move it to shared code on master for the future.