Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 2480143002: wptserve: Don't use copies of testharnessreport.js and vendor-prefix.js. (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wptserve: Don't use copies of testharnessreport.js and vendor-prefix.js. wptserve has the alias feature, and we can map files in LayoutTests/resources/ to web-platform.test/{common,resources}/* without copying. BUG=618366 Committed: https://crrev.com/ed7b4330f51b10e91f8ab32e935ee2c07ad1cdc6 Cr-Commit-Position: refs/heads/master@{#430437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt.config.json View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
qyearsley@, would you review this please?
4 years, 1 month ago (2016-11-07 03:37:07 UTC) #4
qyearsley
On 2016/11/07 at 03:37:07, tkent wrote: > qyearsley@, would you review this please? LGTM :-)
4 years, 1 month ago (2016-11-07 19:35:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480143002/1
4 years, 1 month ago (2016-11-08 00:09:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 00:21:57 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 00:33:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed7b4330f51b10e91f8ab32e935ee2c07ad1cdc6
Cr-Commit-Position: refs/heads/master@{#430437}

Powered by Google App Engine
This is Rietveld 408576698