Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2480133006: arc: Release ScopedHandle (Closed)

Created:
4 years, 1 month ago by hashimoto
Modified:
4 years, 1 month ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Release ScopedHandle The onwership of the handle should be passed to ScopedPlatformHandle. BUG=None Committed: https://crrev.com/a3bf74005d3972afa89df1968a6457ae6ffe6142 Cr-Commit-Position: refs/heads/master@{#430710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/arc/crash_collector/arc_crash_collector_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hashimoto
4 years, 1 month ago (2016-11-08 19:32:20 UTC) #2
hidehiko
lgtm
4 years, 1 month ago (2016-11-08 19:48:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480133006/1
4 years, 1 month ago (2016-11-08 19:50:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 20:58:49 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 21:01:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3bf74005d3972afa89df1968a6457ae6ffe6142
Cr-Commit-Position: refs/heads/master@{#430710}

Powered by Google App Engine
This is Rietveld 408576698