Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2480133003: INPUT element: Move setTextAsOfLastFormControlChangeEvent() call in setValue(). (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT element: Move setTextAsOfLastFormControlChangeEvent() call in setValue(). setTextAsOfLastFormControlChangeEvent() is meaningful only in ValueMode::kValue. So, we move it in HTMLInputElement::setValue() to *InputType::setValue(). Note that InputType::setValue() is used only for ValueMode::kValue. This CL has no behavior changes. Committed: https://crrev.com/ff6af066122d237bb6905ac99d815e673cf860a6 Cr-Commit-Position: refs/heads/master@{#430242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tkent
Keishi, would you review this please?
4 years, 1 month ago (2016-11-07 06:29:40 UTC) #4
keishi
LGTM
4 years, 1 month ago (2016-11-07 06:53:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480133003/1
4 years, 1 month ago (2016-11-07 07:37:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 09:39:43 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 09:42:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff6af066122d237bb6905ac99d815e673cf860a6
Cr-Commit-Position: refs/heads/master@{#430242}

Powered by Google App Engine
This is Rietveld 408576698