Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2480133002: Convert editing/spelling/spelling-on-context-menu-key.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/spelling-on-context-menu-key.html with spellcheck_test This patch converts the layout test with spellcheck_test as a preparation for implementing idle time spellchecker. BUG=517298 Committed: https://crrev.com/401501e80361a94dd9cba0295c6c84dd752e5fcd Cr-Commit-Position: refs/heads/master@{#430227}

Patch Set 1 #

Patch Set 2 : Mon Nov 7 12:15:05 JST 2016 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -49 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spelling-on-context-menu-key.html View 1 1 chunk +22 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/spelling-on-context-menu-key-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-11-07 04:06:14 UTC) #8
yosin_UTC9
lgtm
4 years, 1 month ago (2016-11-07 07:06:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480133002/20001
4 years, 1 month ago (2016-11-07 07:06:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 07:11:04 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 07:12:55 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/401501e80361a94dd9cba0295c6c84dd752e5fcd
Cr-Commit-Position: refs/heads/master@{#430227}

Powered by Google App Engine
This is Rietveld 408576698