Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: content/renderer/history_entry.h

Issue 248013003: Remove WebHistoryItem child usage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moar comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/history_controller.cc ('k') | content/renderer/history_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/history_entry.h
diff --git a/content/renderer/history_entry.h b/content/renderer/history_entry.h
index f8cc14d5d6b33667a98fec6b9372fa57e0a306c3..62da86a4692b8c244aba3696cf4dfbf3b4e5f01d 100644
--- a/content/renderer/history_entry.h
+++ b/content/renderer/history_entry.h
@@ -38,6 +38,7 @@
#include "base/containers/hash_tables.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_vector.h"
+#include "content/common/content_export.h"
#include "third_party/WebKit/public/platform/WebURLRequest.h"
#include "third_party/WebKit/public/web/WebHistoryItem.h"
@@ -51,7 +52,7 @@ class RenderViewImpl;
const int kInvalidFrameRoutingID = -1;
-class HistoryEntry {
+class CONTENT_EXPORT HistoryEntry {
public:
class HistoryNode {
public:
@@ -61,13 +62,14 @@ class HistoryEntry {
~HistoryNode();
HistoryNode* AddChild(const blink::WebHistoryItem& item, int64_t frame_id);
+ HistoryNode* AddChild();
HistoryNode* CloneAndReplace(HistoryEntry* new_entry,
const blink::WebHistoryItem& new_item,
bool clone_children_of_target,
RenderFrameImpl* target_frame,
RenderFrameImpl* current_frame);
blink::WebHistoryItem& item() { return item_; }
- void set_item(const blink::WebHistoryItem& item) { item_ = item; }
+ void set_item(const blink::WebHistoryItem& item);
std::vector<HistoryNode*>& children() const { return children_->get(); }
void RemoveChildren();
@@ -78,6 +80,7 @@ class HistoryEntry {
};
HistoryEntry(const blink::WebHistoryItem& root, int64_t frame_id);
+ HistoryEntry();
~HistoryEntry();
HistoryEntry* CloneAndReplace(const blink::WebHistoryItem& newItem,
@@ -91,7 +94,6 @@ class HistoryEntry {
HistoryNode* root_history_node() const { return root_.get(); }
private:
- HistoryEntry();
scoped_ptr<HistoryNode> root_;
« no previous file with comments | « content/renderer/history_controller.cc ('k') | content/renderer/history_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698