Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Unified Diff: content/renderer/history_controller.h

Issue 248013003: Remove WebHistoryItem child usage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moar comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/context_menu_params_builder.cc ('k') | content/renderer/history_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/history_controller.h
diff --git a/content/renderer/history_controller.h b/content/renderer/history_controller.h
index 0118b0bcf9eb8ea9fdff11bfc2d50b2475fa9c2c..e57bed39e73a0d1bfd01da0cde57bd1188c4fa47 100644
--- a/content/renderer/history_controller.h
+++ b/content/renderer/history_controller.h
@@ -109,23 +109,20 @@ class CONTENT_EXPORT HistoryController {
explicit HistoryController(RenderViewImpl* render_view);
~HistoryController();
- void GoToItem(const blink::WebHistoryItem& item,
- blink::WebURLRequest::CachePolicy cache_policy);
+ void GoToEntry(HistoryEntry* entry,
+ blink::WebURLRequest::CachePolicy cache_policy);
void UpdateForCommit(RenderFrameImpl* frame,
const blink::WebHistoryItem& item,
blink::WebHistoryCommitType commit_type,
bool navigation_within_page);
- blink::WebHistoryItem GetCurrentItemForExport();
- blink::WebHistoryItem GetPreviousItemForExport();
+ HistoryEntry* GetCurrentEntry();
+ HistoryEntry* GetPreviousEntry();
blink::WebHistoryItem GetItemForNewChildFrame(RenderFrameImpl* frame) const;
void RemoveChildrenForRedirect(RenderFrameImpl* frame);
private:
- void GoToEntry(HistoryEntry* entry,
- blink::WebURLRequest::CachePolicy cache_policy);
-
typedef std::vector<std::pair<blink::WebFrame*, blink::WebHistoryItem> >
HistoryFrameLoadVector;
void RecursiveGoToEntry(blink::WebFrame* frame,
« no previous file with comments | « content/renderer/context_menu_params_builder.cc ('k') | content/renderer/history_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698