Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2480043002: Compile fuzzer sources in standalone builds. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
dsinclair, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Compile fuzzer sources in standalone builds. - Add a template for fuzzers to remove redundancy. - Sort fuzzers in alphabetical order. Committed: https://pdfium.googlesource.com/pdfium/+/470b5fa8f8dbfd2aa702d9d8cfdc03a7b486b374

Patch Set 1 #

Patch Set 2 : Add pdfium_fuzzer GN template #

Patch Set 3 : Sort fuzzer targets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -176 lines) Patch
M BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M testing/libfuzzer/BUILD.gn View 1 2 2 chunks +49 lines, -176 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Lei Zhang
4 years, 1 month ago (2016-11-05 06:50:58 UTC) #9
dsinclair
lgtm
4 years, 1 month ago (2016-11-07 14:15:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480043002/40001
4 years, 1 month ago (2016-11-07 14:15:13 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://pdfium.googlesource.com/pdfium/+/470b5fa8f8dbfd2aa702d9d8cfdc03a7b486b374
4 years, 1 month ago (2016-11-07 14:24:52 UTC) #16
npm
win_xfa_32 is not compiling fuzzers
4 years, 1 month ago (2016-11-07 16:31:58 UTC) #18
npm
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2480323002/ by npm@chromium.org. ...
4 years, 1 month ago (2016-11-07 16:33:50 UTC) #19
Lei Zhang
4 years, 1 month ago (2016-11-07 18:46:40 UTC) #20
Message was sent while issue was closed.
And bug https://bugs.chromium.org/p/pdfium/issues/detail?id=627 strikes!

Powered by Google App Engine
This is Rietveld 408576698