Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2480033002: Prevent reloading the PDF embedded in the print preview. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent reloading the PDF embedded in the print preview. BUG=662305 Committed: https://crrev.com/6a1fd28e635fd50afa36d5f8e4d4e4e4e4912292 Cr-Commit-Position: refs/heads/master@{#430399}

Patch Set 1 : Prevent reloading the PDF embedded in the print preview. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Lei Zhang
4 years, 1 month ago (2016-11-07 19:03:08 UTC) #10
Evan Stade
lgtm
4 years, 1 month ago (2016-11-07 22:06:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480033002/20001
4 years, 1 month ago (2016-11-07 22:19:16 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-07 22:27:55 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 22:40:17 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a1fd28e635fd50afa36d5f8e4d4e4e4e4912292
Cr-Commit-Position: refs/heads/master@{#430399}

Powered by Google App Engine
This is Rietveld 408576698