Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: content/renderer/media/android/renderer_media_player_manager.cc

Issue 2480003002: [RemotePlayback] Keep track of source compatibility and reject prompt() correspondingly (Closed)
Patch Set: Rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/renderer_media_player_manager.cc
diff --git a/content/renderer/media/android/renderer_media_player_manager.cc b/content/renderer/media/android/renderer_media_player_manager.cc
index 27ebfd7f54e53fefbefe754ecc7f4d29226494eb..9aa86814f7568682eae87a690820e872275d0d69 100644
--- a/content/renderer/media/android/renderer_media_player_manager.cc
+++ b/content/renderer/media/android/renderer_media_player_manager.cc
@@ -10,10 +10,13 @@
#include "content/renderer/media/android/webmediaplayer_android.h"
#include "content/renderer/render_view_impl.h"
#include "media/base/media_switches.h"
+#include "third_party/WebKit/public/platform/modules/remoteplayback/WebRemotePlaybackAvailability.h"
#include "ui/gfx/geometry/rect_f.h"
namespace content {
+using ::blink::WebRemotePlaybackAvailability;
+
RendererMediaPlayerManager::RendererMediaPlayerManager(
RenderFrame* render_frame)
: RenderFrameObserver(render_frame),
@@ -244,10 +247,21 @@ void RendererMediaPlayerManager::OnPlayerPause(int player_id) {
void RendererMediaPlayerManager::OnRemoteRouteAvailabilityChanged(
int player_id,
- bool routes_available) {
+ bool is_route_available,
+ bool is_source_compatible) {
media::RendererMediaPlayerInterface* player = GetMediaPlayer(player_id);
- if (player)
- player->OnRemoteRouteAvailabilityChanged(routes_available);
+ if (player) {
+ WebRemotePlaybackAvailability availability =
+ WebRemotePlaybackAvailability::DeviceNotAvailable;
+ if (is_route_available && is_source_compatible) {
+ availability = WebRemotePlaybackAvailability::DeviceAvailable;
+ } else if (!is_route_available && !is_source_compatible) {
+ availability = WebRemotePlaybackAvailability::SourceNotSupported;
+ } else if (is_route_available) {
+ availability = WebRemotePlaybackAvailability::SourceNotCompatible;
+ }
+ player->OnRemoteRouteAvailabilityChanged(availability);
+ }
}
void RendererMediaPlayerManager::EnterFullscreen(int player_id) {

Powered by Google App Engine
This is Rietveld 408576698