Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js

Issue 2479973002: MD Settings: clarify "controlled by" logic (Closed)
Patch Set: merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
diff --git a/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js b/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
index 4d2cee4caf622784d9ea9128d16343c211bc451b..ce0da18641e299295ab48a8c492b62e8140a7417 100644
--- a/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
+++ b/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
@@ -9,7 +9,6 @@
/** @enum {string} */
var CrPolicyIndicatorType = {
DEVICE_POLICY: 'devicePolicy',
- EXTENSION: 'extension',
NONE: 'none',
OWNER: 'owner',
PRIMARY_USER: 'primary_user',
@@ -49,9 +48,6 @@ var CrPolicyIndicatorBehavior = {
case CrPolicyIndicatorType.RECOMMENDED:
icon = 'domain';
break;
- case CrPolicyIndicatorType.EXTENSION:
- icon = 'extension';
- break;
default:
assertNotReached();
}
@@ -70,7 +66,7 @@ var CrPolicyIndicatorBehavior = {
/**
* @param {CrPolicyIndicatorType} type
* @param {string} name The name associated with the controllable. See
- * chrome.settingsPrivate.PrefObject.policySourceName
+ * chrome.settingsPrivate.PrefObject.controlledByName
* @return {string} The tooltip text for |type|.
*/
getPolicyIndicatorTooltip: function(type, name) {
@@ -82,8 +78,6 @@ var CrPolicyIndicatorBehavior = {
case CrPolicyIndicatorType.USER_POLICY:
case CrPolicyIndicatorType.DEVICE_POLICY:
return this.i18n_('controlledSettingPolicy');
- case CrPolicyIndicatorType.EXTENSION:
- return this.i18n_('controlledSettingExtension', name);
case CrPolicyIndicatorType.RECOMMENDED:
// This case is not handled here since it requires knowledge of the
// value and recommended value associated with the controllable.

Powered by Google App Engine
This is Rietveld 408576698