MD Settings: clarify "controlled by" logic

ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js

Index: ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
diff --git a/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js b/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
index 4d2cee4caf622784d9ea9128d16343c211bc451b..ce0da18641e299295ab48a8c492b62e8140a7417 100644
--- a/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
+++ b/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
@@ -9,7 +9,6 @@
 /** @enum {string} */
 var CrPolicyIndicatorType = {
   DEVICE_POLICY: 'devicePolicy',
-  EXTENSION: 'extension',
   NONE: 'none',
   OWNER: 'owner',
   PRIMARY_USER: 'primary_user',
@@ -49,9 +48,6 @@ var CrPolicyIndicatorBehavior = {
       case CrPolicyIndicatorType.RECOMMENDED:
         icon = 'domain';
         break;
-      case CrPolicyIndicatorType.EXTENSION:
-        icon = 'extension';
-        break;

[stevenjb, 2016/11/12 01:31:46]

I'm using this in the networking proxy code (for now anyway):
https://codereview.chromium.org/2467123003/

Can we leave this in for now? We can fix up that UI later and eliminate this
later.

[Dan Beam, 2016/11/15 05:38:39]

we talked about this over chat.  you said:

"""
So yeah, let's go ahead and remove it from there and create an element that
matches the mocks.
[snip]
I'll update the per-network proxy settings with that once we have other
examples.
"""

creating the UI is the next step

[stevenjb, 2016/11/15 22:11:19]

Acknowledged.

       default:
         assertNotReached();
     }
@@ -70,7 +66,7 @@ var CrPolicyIndicatorBehavior = {
   /**
    * @param {CrPolicyIndicatorType} type
    * @param {string} name The name associated with the controllable. See
-   *     chrome.settingsPrivate.PrefObject.policySourceName
+   *     chrome.settingsPrivate.PrefObject.controlledByName
    * @return {string} The tooltip text for |type|.
    */
   getPolicyIndicatorTooltip: function(type, name) {
@@ -82,8 +78,6 @@ var CrPolicyIndicatorBehavior = {
       case CrPolicyIndicatorType.USER_POLICY:
       case CrPolicyIndicatorType.DEVICE_POLICY:
         return this.i18n_('controlledSettingPolicy');
-      case CrPolicyIndicatorType.EXTENSION:
-        return this.i18n_('controlledSettingExtension', name);
       case CrPolicyIndicatorType.RECOMMENDED:
         // This case is not handled here since it requires knowledge of the
         // value and recommended value associated with the controllable.