chrome/browser/resources/settings/controls/settings_checkbox.html - Issue 2479973002: MD Settings: clarify "controlled by" logic

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/controls/settings_checkbox.html

Issue 2479973002: MD Settings: clarify "controlled by" logic (Closed)

Patch Set: merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/settings_private/prefs_util.cc ('K') | « chrome/browser/resources/settings/controls/controlled_button.js ('k') | chrome/browser/resources/settings/controls/settings_input.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">

3 <link rel="import" href="/controls/settings_boolean_control_behavior.html">	3 <link rel="import" href="/controls/settings_boolean_control_behavior.html">

4 <link rel="import" href="/settings_shared_css.html">	4 <link rel="import" href="/settings_shared_css.html">

5	5

6 <dom-module id="settings-checkbox">	6 <dom-module id="settings-checkbox">

7 <template>	7 <template>

8 <style include="settings-shared">	8 <style include="settings-shared">

9 #outerRow {	9 #outerRow {

10 align-items: center;	10 align-items: center;

(...skipping 17 matching lines...) Expand all Loading...
28 cr-policy-pref-indicator {	28 cr-policy-pref-indicator {

29 -webkit-margin-start: var(--checkbox-spacing);	29 -webkit-margin-start: var(--checkbox-spacing);

30 }	30 }

31 </style>	31 </style>

32 <div id="outerRow" noSubLabel$="[[!subLabel]]">	32 <div id="outerRow" noSubLabel$="[[!subLabel]]">

33 <paper-checkbox id="checkbox" checked="{{checked}}"	33 <paper-checkbox id="checkbox" checked="{{checked}}"

34 disabled="[[controlDisabled_(disabled, pref)]]">	34 disabled="[[controlDisabled_(disabled, pref)]]">

35 <div>[[label]]</div>	35 <div>[[label]]</div>

36 <div class="secondary">[[subLabel]]</div>	36 <div class="secondary">[[subLabel]]</div>

37 </paper-checkbox>	37 </paper-checkbox>

38 <template is="dom-if" if="[[pref.policySource]]">	38 <template is="dom-if" if="[[pref.controlledBy]]">

39 <cr-policy-pref-indicator pref="[[pref]]"></cr-policy-pref-indicator>	39 <cr-policy-pref-indicator pref="[[pref]]"></cr-policy-pref-indicator>

40 </template>	40 </template>

41 </div>	41 </div>

42 </template>	42 </template>

43 <script src="settings_checkbox.js"></script>	43 <script src="settings_checkbox.js"></script>

44 </dom-module>	44 </dom-module>

OLD	NEW