Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2479963002:
Fix more flaky OOPIF tests by waiting for the old RenderFrame to be deleted. (Closed)
|
Created:
4 years, 1 month ago by Charlie Reis Modified:
4 years, 1 month ago Reviewers:
Łukasz Anforowicz CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, ncarter (slow), site-isolation-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix more flaky OOPIF tests by waiting for the old RenderFrame to be deleted.
This fixes the following tests in --site-per-process mode:
NavigationControllerBrowserTest.FrameNavigationEntry_NewSubframe
FrameTreeBrowserTest.NavigateGrandchildToBlob
BUG=662550, 646836
TEST=Bots stay green.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/b2d5f1f334cfeab18119f38708d0cd191e4eac2f
Cr-Commit-Position: refs/heads/master@{#430412}
Patch Set 1 #Patch Set 2 : Fix another case. #
Total comments: 2
Messages
Total messages: 21 (14 generated)
Description was changed from ========== Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted. This fixes the following tests in --site-per-process mode: NavigationControllerBrowserTest.FrameNavigationEntry_NewSubframe FrameTreeBrowserTest.NavigateGrandchildToBlob BUG=662550, 646836 TEST=Bots stay green. ========== to ========== Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted. This fixes the following tests in --site-per-process mode: NavigationControllerBrowserTest.FrameNavigationEntry_NewSubframe FrameTreeBrowserTest.NavigateGrandchildToBlob BUG=662550, 646836 TEST=Bots stay green. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by creis@chromium.org to run a CQ dry run
creis@chromium.org changed reviewers: + lukasza@chromium.org
Here's the other 2. :)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by creis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted. This fixes the following tests in --site-per-process mode: NavigationControllerBrowserTest.FrameNavigationEntry_NewSubframe FrameTreeBrowserTest.NavigateGrandchildToBlob BUG=662550, 646836 TEST=Bots stay green. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix more flaky OOPIF tests by waiting for the old RenderFrame to be deleted. This fixes the following tests in --site-per-process mode: NavigationControllerBrowserTest.FrameNavigationEntry_NewSubframe FrameTreeBrowserTest.NavigateGrandchildToBlob BUG=662550, 646836 TEST=Bots stay green. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Fixed another case in this CL as well (separate from https://codereview.chromium.org/2478933002/), and sent for more try jobs.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2479963002/diff/20001/content/browser/frame_h... File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/2479963002/diff/20001/content/browser/frame_h... content/browser/frame_host/navigation_controller_impl_browsertest.cc:2272: NavigateFrameToURL(root->child_at(0), frame_url2); No need for RenderFrameDeletedObserver here? Is this because this is a same-site navigation?
https://codereview.chromium.org/2479963002/diff/20001/content/browser/frame_h... File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/2479963002/diff/20001/content/browser/frame_h... content/browser/frame_host/navigation_controller_impl_browsertest.cc:2272: NavigateFrameToURL(root->child_at(0), frame_url2); On 2016/11/07 22:13:25, Łukasz Anforowicz wrote: > No need for RenderFrameDeletedObserver here? Is this because this is a > same-site navigation? Correct. The RenderFrame won't be deleted on same-site navigations, so it would just wait forever and time out.
The CQ bit was checked by creis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix more flaky OOPIF tests by waiting for the old RenderFrame to be deleted. This fixes the following tests in --site-per-process mode: NavigationControllerBrowserTest.FrameNavigationEntry_NewSubframe FrameTreeBrowserTest.NavigateGrandchildToBlob BUG=662550, 646836 TEST=Bots stay green. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix more flaky OOPIF tests by waiting for the old RenderFrame to be deleted. This fixes the following tests in --site-per-process mode: NavigationControllerBrowserTest.FrameNavigationEntry_NewSubframe FrameTreeBrowserTest.NavigateGrandchildToBlob BUG=662550, 646836 TEST=Bots stay green. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix more flaky OOPIF tests by waiting for the old RenderFrame to be deleted. This fixes the following tests in --site-per-process mode: NavigationControllerBrowserTest.FrameNavigationEntry_NewSubframe FrameTreeBrowserTest.NavigateGrandchildToBlob BUG=662550, 646836 TEST=Bots stay green. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix more flaky OOPIF tests by waiting for the old RenderFrame to be deleted. This fixes the following tests in --site-per-process mode: NavigationControllerBrowserTest.FrameNavigationEntry_NewSubframe FrameTreeBrowserTest.NavigateGrandchildToBlob BUG=662550, 646836 TEST=Bots stay green. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/b2d5f1f334cfeab18119f38708d0cd191e4eac2f Cr-Commit-Position: refs/heads/master@{#430412} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b2d5f1f334cfeab18119f38708d0cd191e4eac2f Cr-Commit-Position: refs/heads/master@{#430412} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
