Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2479913002: win: Don't define TOOLKIT_VIEWS in build_config.h (Closed)

Created:
4 years, 1 month ago by Nico
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Don't define TOOLKIT_VIEWS in build_config.h ui/views/BUILD.gn adds this as a define in gn, so rely on that on Windows just like we do on other platforms that use views. No intended behavior change. BUG= Committed: https://crrev.com/b0df253516308e693edfe25b161efd3db85f980d Cr-Commit-Position: refs/heads/master@{#430017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/build_config.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
You added this 7.5 years ago in https://codereview.chromium.org/113321
4 years, 1 month ago (2016-11-04 19:31:05 UTC) #3
sky
7.5 years go, eh? LGTM
4 years, 1 month ago (2016-11-04 20:46:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479913002/1
4 years, 1 month ago (2016-11-04 21:09:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 21:15:40 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 21:18:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0df253516308e693edfe25b161efd3db85f980d
Cr-Commit-Position: refs/heads/master@{#430017}

Powered by Google App Engine
This is Rietveld 408576698