Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2479883003:
[Mac] Fix for find bar text issue (Closed)
|
Created:
4 years, 1 month ago by spqchan Modified:
4 years, 1 month ago Reviewers:
Robert Sesek CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Fix for find bar text issue
|-resetFieldEditorFrameIfNeeded| only draws if the frame has changed.
Ensure that the find bar gets redrawn, even when the frame stays the same.
BUG=647078
Committed: https://crrev.com/a779a7e195f1fb8f7a044355f96cf8b4fb272fde
Cr-Commit-Position: refs/heads/master@{#430384}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== [Mac] Fix for find bar text issue BUG=647078 ========== to ========== [Mac] Fix for find bar text issue |-resetFieldEditorFrameIfNeeded| only draws if the frame has changed. Ensure that the find bar gets redrawn, even when the frame stays the same. BUG=647078 ==========
spqchan@chromium.org changed reviewers: + rsesek@chromium.org
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
lgtm
On 2016/11/07 19:40:19, Robert Sesek wrote: > lgtm thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix for find bar text issue |-resetFieldEditorFrameIfNeeded| only draws if the frame has changed. Ensure that the find bar gets redrawn, even when the frame stays the same. BUG=647078 ========== to ========== [Mac] Fix for find bar text issue |-resetFieldEditorFrameIfNeeded| only draws if the frame has changed. Ensure that the find bar gets redrawn, even when the frame stays the same. BUG=647078 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix for find bar text issue |-resetFieldEditorFrameIfNeeded| only draws if the frame has changed. Ensure that the find bar gets redrawn, even when the frame stays the same. BUG=647078 ========== to ========== [Mac] Fix for find bar text issue |-resetFieldEditorFrameIfNeeded| only draws if the frame has changed. Ensure that the find bar gets redrawn, even when the frame stays the same. BUG=647078 Committed: https://crrev.com/a779a7e195f1fb8f7a044355f96cf8b4fb272fde Cr-Commit-Position: refs/heads/master@{#430384} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a779a7e195f1fb8f7a044355f96cf8b4fb272fde Cr-Commit-Position: refs/heads/master@{#430384} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
