Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2479863003: Revert of Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted. (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, ncarter (slow), site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted. (patchset #1 id:1 of https://codereview.chromium.org/2478933002/ ) Reason for revert: Causing flakiness still: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/23876 Original issue's description: > Fix flaky OOPIF tests by waiting for the old RenderFrame to be deleted. > > This fixes: > SitePerProcessBrowserTest.CrossSiteIframe > SitePerProcessBrowserTest.NavigateRemoteFrame > SitePerProcessBrowserTest.RFPHDestruction > TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup2 > TopDocumentIsolationTest.FramesForSitesInHistory > > BUG=662550, 629419, 611300, 611344 > TEST=Bots stay green. > > Committed: https://crrev.com/7a65c0019399f0a7052ab13bc73439acb116adb8 > Cr-Commit-Position: refs/heads/master@{#430081} TBR=lukasza@chromium.org,creis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=662550, 629419, 611300, 611344 Committed: https://crrev.com/c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f Cr-Commit-Position: refs/heads/master@{#430145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -50 lines) Patch
M content/browser/site_per_process_browsertest.cc View 7 chunks +23 lines, -11 lines 0 comments Download
M content/browser/top_document_isolation_browsertest.cc View 7 chunks +19 lines, -39 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mathieu
Created Revert of Fix flaky OOPIF tests by waiting for the old RenderFrame to be ...
4 years, 1 month ago (2016-11-05 03:39:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479863003/1
4 years, 1 month ago (2016-11-05 03:40:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 03:41:24 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 03:44:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6abe5bfc52cc830ee64a6277e19a8ad0fa71e2f
Cr-Commit-Position: refs/heads/master@{#430145}

Powered by Google App Engine
This is Rietveld 408576698