sync/internal_api/public/base_transaction.h - Issue 247983002: Keep track of which attachments are referenced by which sync entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base_transaction.h

Issue 247983002: Keep track of which attachments are referenced by which sync entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rework tests and move AttachmentIdProto creation to avoid violating DEPS. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/base_transaction.h

diff --git a/sync/internal_api/public/base_transaction.h b/sync/internal_api/public/base_transaction.h

index 2f4fa3c91b103ebf24a8c020dfdb05f7c76e1b21..c75086e526f6e3fb2d1b12c248fec925c9638b34 100644

--- a/sync/internal_api/public/base_transaction.h

+++ b/sync/internal_api/public/base_transaction.h

@@ -24,6 +24,9 @@ class Directory;

// syncable, and are used in a similar way. Unlike syncable::BaseTransaction,

// whose construction requires an explicit syncable::Directory, a sync

// API BaseTransaction is created from a UserShare object.

+//

+// Note, these transactions are not atomic. Individual operations can

+// fail. There is no built-in rollback or undo mechanism.

class SYNC_EXPORT BaseTransaction {

public:

// Provide access to the underlying syncable objects from BaseNode.