sync/api/attachments/attachment_service_proxy.h - Issue 247983002: Keep track of which attachments are referenced by which sync entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/attachment_service_proxy.h

Issue 247983002: Keep track of which attachments are referenced by which sync entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rework tests and move AttachmentIdProto creation to avoid violating DEPS. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/api/attachments/attachment_service_proxy.h

diff --git a/sync/api/attachments/attachment_service_proxy.h b/sync/api/attachments/attachment_service_proxy.h

index 70856255cfa56d43b445468f7c650186ea858a7b..462cddadea97ac54d63a6a707abb30a4dfb8f05a 100644

--- a/sync/api/attachments/attachment_service_proxy.h

+++ b/sync/api/attachments/attachment_service_proxy.h

@@ -58,7 +58,8 @@ class SYNC_EXPORT AttachmentServiceProxy : public AttachmentService {

const GetOrDownloadCallback& callback) OVERRIDE;

virtual void DropAttachments(const AttachmentIdList& attachment_ids,

const DropCallback& callback) OVERRIDE;

- virtual void OnSyncDataAdd(const SyncData& sync_data) OVERRIDE;

+ virtual void StoreAttachments(const AttachmentList& attachment,

+ const StoreCallback& callback) OVERRIDE;

virtual void OnSyncDataDelete(const SyncData& sync_data) OVERRIDE;

virtual void OnSyncDataUpdate(const AttachmentIdList& old_attachment_ids,

const SyncData& updated_sync_data) OVERRIDE;

@@ -89,7 +90,8 @@ class SYNC_EXPORT AttachmentServiceProxy : public AttachmentService {