Keep track of which attachments are referenced by which sync entries.

sync/engine/get_commit_ids.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/engine/get_commit_ids.h"
 
 #include <set>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 90 matching lines @@
     DVLOG(1) << "Excluding entry from commit due to version mismatch "
              << entry;
     return true;
   }
   return false;
 }
 
 // Return true if this entry has any attachments that haven't yet been uploaded
 // to the server.
 bool HasAttachmentNotOnServer(const syncable::Entry& entry) {
-  // TODO(maniscalco): Once AttachmentMetadata is fleshed out, implement this
-  // function to return true if any of the attachments haven't been uploaded to
-  // the server. Add test case (bug 356266).
+  // TODO(maniscalco): Add test case (bug 356266).
+  const sync_pb::AttachmentMetadata& metadata = entry.GetAttachmentMetadata();
+  for (int i = 0; i < metadata.record_size(); ++i) {
+    if (!metadata.record(i).is_on_server()) {
+      return true;
+    }
+  }
   return false;
 }
 
 // An entry is not considered ready for commit if any are true:
 // 1. It's in conflict.
 // 2. It requires encryption (either the type is encrypted but a passphrase
 //    is missing from the cryptographer, or the entry itself wasn't properly
 //    encrypted).
 // 3. It's type is currently throttled.
 // 4. It's a delete but has not been committed.
@@ skipping 396 matching lines @@
   // Add moves and creates, and prepend their uncommitted parents.
   traversal.AddCreatesAndMoves(ready_unsynced_set);
 
   // Add all deletes.
   traversal.AddDeletes(ready_unsynced_set);
 }
 
 }  // namespace
 
 }  // namespace syncer