sync/syncable/DEPS - Issue 247983002: Keep track of which attachments are referenced by which sync entries.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/syncable/DEPS

Issue 247983002: Keep track of which attachments are referenced by which sync entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: FakeAttachmentService::StoreAttachments now calls AttachmentStore::Write. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+net/base/escape.h",	2 "+net/base/escape.h",

3 "+sql",	3 "+sql",

	4 "+sync/api",

4 "+sync/base",	5 "+sync/base",

	6 "+sync/internal_api/public",
	pavely 2014/04/30 20:22:12 Could you take a look at comments between me and T Could you take a look at comments between me and Tim about similar change: https://codereview.chromium.org/248473002/diff/1/sync/engine/DEPS https://codereview.chromium.org/250943003/diff/1/sync/internal_api/public/bas... maniscalco 2014/05/01 00:34:16 Thanks for pointing this out! I had a conversatio Show quoted text On 2014/04/30 20:22:12, pavely wrote: > Could you take a look at comments between me and Tim about similar change: > > https://codereview.chromium.org/248473002/diff/1/sync/engine/DEPS > > https://codereview.chromium.org/250943003/diff/1/sync/internal_api/public/bas... Thanks for pointing this out! I had a conversation with Tim about DEPS. Adding these news allowances would have been a mistake so I've done three things to rectify the situation. 1. I've moved the AttachmentIdProto initialization out of sync/api and into sync/internal_api/base where sync/syncable can depend on it. Directory and friends have been updated to reflect this move. 2. I've moved the AttachmentLinking test case to sync_manager_impl_unittest.cc, which is an arguably better home for it since it used the internal_api layer, not the syncable layer. 3. I've added more test cases to directory_unittest.cc that test Directory using the syncable layer, which fits with the other test cases in the file.
5 "+sync/internal_api/public/base",	7 "+sync/internal_api/public/base",

6 "+sync/internal_api/public/engine",	8 "+sync/internal_api/public/engine",

7 "+sync/internal_api/public/util",	9 "+sync/internal_api/public/util",

8 "+sync/protocol",	10 "+sync/protocol",

9 "+sync/test",	11 "+sync/test",

10 "+sync/util",	12 "+sync/util",

11 ]	13 ]

OLD	NEW

« no previous file with comments | « sync/protocol/attachments.proto ('k') | sync/syncable/directory.h » ('j') | no next file with comments »