Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: test/cctest/test-serialize.cc

Issue 2479823002: [test] no longer disable turbofan for serializer tests. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-serialize.cc
diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc
index dd0a101bbc044e947ba1de78c82ae64fae5ffdf7..a47ecc637c7999accac087d66c799b43e9639f14 100644
--- a/test/cctest/test-serialize.cc
+++ b/test/cctest/test-serialize.cc
@@ -50,12 +50,6 @@
using namespace v8::internal;
-void DisableTurbofan() {
- const char* flag = "--turbo-filter=\"\"";
- FlagList::SetFlagsFromString(flag, StrLength(flag));
-}
-
-
// TestIsolate is used for testing isolate serialization.
class TestIsolate : public Isolate {
public:
@@ -150,10 +144,6 @@ static void SanityCheck(v8::Isolate* v8_isolate) {
}
UNINITIALIZED_TEST(StartupSerializerOnce) {
- // The serialize-deserialize tests only work if the VM is built without
- // serialization. That doesn't matter. We don't need to be able to
- // serialize a snapshot in a VM that is booted from a snapshot.
Yang 2016/11/04 09:00:29 This comment doesn't make any sense nowadays.
- DisableTurbofan();
v8::Isolate* isolate = TestIsolate::NewInitialized(true);
Vector<const byte> blob = Serialize(isolate);
isolate = Deserialize(blob);
@@ -171,7 +161,6 @@ UNINITIALIZED_TEST(StartupSerializerOnce) {
}
UNINITIALIZED_TEST(StartupSerializerTwice) {
- DisableTurbofan();
v8::Isolate* isolate = TestIsolate::NewInitialized(true);
Vector<const byte> blob1 = Serialize(isolate);
Vector<const byte> blob2 = Serialize(isolate);
@@ -191,7 +180,6 @@ UNINITIALIZED_TEST(StartupSerializerTwice) {
}
UNINITIALIZED_TEST(StartupSerializerOnceRunScript) {
- DisableTurbofan();
v8::Isolate* isolate = TestIsolate::NewInitialized(true);
Vector<const byte> blob = Serialize(isolate);
isolate = Deserialize(blob);
@@ -215,7 +203,6 @@ UNINITIALIZED_TEST(StartupSerializerOnceRunScript) {
}
UNINITIALIZED_TEST(StartupSerializerTwiceRunScript) {
- DisableTurbofan();
v8::Isolate* isolate = TestIsolate::NewInitialized(true);
Vector<const byte> blob1 = Serialize(isolate);
Vector<const byte> blob2 = Serialize(isolate);
@@ -303,7 +290,6 @@ static void PartiallySerializeObject(Vector<const byte>* startup_blob_out,
}
UNINITIALIZED_TEST(PartialSerializerObject) {
- DisableTurbofan();
Vector<const byte> startup_blob;
Vector<const byte> partial_blob;
PartiallySerializeObject(&startup_blob, &partial_blob);
@@ -401,7 +387,6 @@ static void PartiallySerializeContext(Vector<const byte>* startup_blob_out,
}
UNINITIALIZED_TEST(PartialSerializerContext) {
- DisableTurbofan();
Vector<const byte> startup_blob;
Vector<const byte> partial_blob;
PartiallySerializeContext(&startup_blob, &partial_blob);
@@ -520,7 +505,6 @@ static void PartiallySerializeCustomContext(
}
UNINITIALIZED_TEST(PartialSerializerCustomContext) {
- DisableTurbofan();
Vector<const byte> startup_blob;
Vector<const byte> partial_blob;
PartiallySerializeCustomContext(&startup_blob, &partial_blob);
@@ -610,7 +594,6 @@ UNINITIALIZED_TEST(PartialSerializerCustomContext) {
}
TEST(CustomSnapshotDataBlob) {
- DisableTurbofan();
const char* source1 = "function f() { return 42; }";
const char* source2 =
"function f() { return g() * 2; }"
@@ -664,8 +647,6 @@ static void SerializationFunctionTemplate(
}
TEST(CustomSnapshotDataBlobOutdatedContextWithOverflow) {
- DisableTurbofan();
-
const char* source1 =
"var o = {};"
"(function() {"
@@ -710,7 +691,6 @@ TEST(CustomSnapshotDataBlobOutdatedContextWithOverflow) {
}
TEST(CustomSnapshotDataBlobWithLocker) {
- DisableTurbofan();
v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
v8::Isolate* isolate0 = v8::Isolate::New(create_params);
@@ -748,7 +728,6 @@ TEST(CustomSnapshotDataBlobWithLocker) {
}
TEST(CustomSnapshotDataBlobStackOverflow) {
- DisableTurbofan();
const char* source =
"var a = [0];"
"var b = a;"
@@ -794,7 +773,6 @@ bool IsCompiled(const char* name) {
}
TEST(SnapshotDataBlobWithWarmup) {
- DisableTurbofan();
const char* warmup = "Math.abs(1); Math.random = 1;";
v8::StartupData cold = v8::V8::CreateSnapshotDataBlob();
@@ -822,7 +800,6 @@ TEST(SnapshotDataBlobWithWarmup) {
}
TEST(CustomSnapshotDataBlobWithWarmup) {
- DisableTurbofan();
const char* source =
"function f() { return Math.abs(1); }\n"
"function g() { return String.raw(1); }\n"
@@ -858,7 +835,6 @@ TEST(CustomSnapshotDataBlobWithWarmup) {
}
TEST(CustomSnapshotDataBlobImmortalImmovableRoots) {
- DisableTurbofan();
// Flood the startup snapshot with shared function infos. If they are
// serialized before the immortal immovable root, the root will no longer end
// up on the first page.
@@ -1949,7 +1925,6 @@ TEST(CodeSerializerEmbeddedObject) {
}
TEST(SnapshotCreatorMultipleContexts) {
- DisableTurbofan();
v8::StartupData blob;
{
v8::SnapshotCreator creator;
@@ -2026,7 +2001,6 @@ intptr_t replaced_external_references[] = {
reinterpret_cast<intptr_t>(SerializedCallbackReplacement), 0};
TEST(SnapshotCreatorExternalReferences) {
- DisableTurbofan();
v8::StartupData blob;
{
v8::SnapshotCreator creator(original_external_references);
@@ -2086,7 +2060,6 @@ TEST(SnapshotCreatorExternalReferences) {
}
TEST(SnapshotCreatorUnknownExternalReferences) {
- DisableTurbofan();
v8::SnapshotCreator creator;
v8::Isolate* isolate = creator.GetIsolate();
{
@@ -2132,7 +2105,6 @@ void DeserializeInternalFields(v8::Local<v8::Object> holder, int index,
}
TEST(SnapshotCreatorTemplates) {
- DisableTurbofan();
v8::StartupData blob;
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698