Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2479823002: [test] no longer disable turbofan for serializer tests. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] no longer disable turbofan for serializer tests. This is no longer necessary. Isolates created for serialization have optimization disabled anyways. R=jkummerow@chromium.org Committed: https://crrev.com/1dba86339f2b2be7d027f13f9eac17aba27d45cb Cr-Commit-Position: refs/heads/master@{#40761}

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M test/cctest/test-serialize.cc View 1 20 chunks +23 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Yang
4 years, 1 month ago (2016-11-04 08:59:32 UTC) #1
Yang
https://codereview.chromium.org/2479823002/diff/1/test/cctest/test-serialize.cc File test/cctest/test-serialize.cc (left): https://codereview.chromium.org/2479823002/diff/1/test/cctest/test-serialize.cc#oldcode155 test/cctest/test-serialize.cc:155: // serialize a snapshot in a VM that is ...
4 years, 1 month ago (2016-11-04 09:00:29 UTC) #2
Yang
On 2016/11/04 09:00:29, Yang wrote: > https://codereview.chromium.org/2479823002/diff/1/test/cctest/test-serialize.cc > File test/cctest/test-serialize.cc (left): > > https://codereview.chromium.org/2479823002/diff/1/test/cctest/test-serialize.cc#oldcode155 > ...
4 years, 1 month ago (2016-11-04 10:00:07 UTC) #7
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-04 12:01:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479823002/20001
4 years, 1 month ago (2016-11-04 12:05:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 12:29:26 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:35 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1dba86339f2b2be7d027f13f9eac17aba27d45cb
Cr-Commit-Position: refs/heads/master@{#40761}

Powered by Google App Engine
This is Rietveld 408576698