Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2479773002: Add chrome namespace to chrome/common/shell_handler_win.mojom (Closed)

Created:
4 years, 1 month ago by nigeltao1
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome namespace to chrome/common/shell_handler_win.mojom BUG= Committed: https://crrev.com/fba34dd108a2374e90b4fbdbfb081c093759f99c Cr-Commit-Position: refs/heads/master@{#433114}

Patch Set 1 #

Patch Set 2 : Add chrome namespace to chrome/common/shell_handler_win.mojom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M chrome/browser/chrome_content_utility_manifest_overlay.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/welcome_win10_handler.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/welcome_win10_handler.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/shell_handler_win.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/shell_handler_impl_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/utility/shell_handler_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
nigeltao1
4 years, 1 month ago (2016-11-05 23:35:36 UTC) #6
nigeltao1
4 years, 1 month ago (2016-11-10 01:24:00 UTC) #7
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-11-10 17:24:22 UTC) #8
nigeltao1
sky, tsepez, can you review for OWNERS?
4 years, 1 month ago (2016-11-17 03:57:45 UTC) #10
Tom Sepez
OWNERS LGTM
4 years, 1 month ago (2016-11-17 17:03:24 UTC) #11
sky
LGTM
4 years, 1 month ago (2016-11-17 19:03:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479773002/1
4 years, 1 month ago (2016-11-18 01:02:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/334601) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 1 month ago (2016-11-18 01:30:18 UTC) #16
nigeltao1
Ah, b9f756c3 introduced a new mojom::ShellHandler reference.
4 years, 1 month ago (2016-11-18 03:27:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479773002/20001
4 years, 1 month ago (2016-11-18 03:39:24 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 04:47:31 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 04:56:44 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fba34dd108a2374e90b4fbdbfb081c093759f99c
Cr-Commit-Position: refs/heads/master@{#433114}

Powered by Google App Engine
This is Rietveld 408576698