Stop preloading scripts that have invalid type/language attributes

Stop preloading scripts that have invalid type/language attributes

This patch removes prefetching of scripts that have invalid type/language
attributes, and removes the deprecation warning. This also adds/edits tests
accordingly.

BUG=626321
Committed: https://crrev.com/f76c6bc7e8fa6e1ca60101ab3dfc35ba7a40594c
Cr-Commit-Position: refs/heads/master@{#431277}

[cfredric, 2016-11-04 19:12:13]

I migrated this patch from my @google acct to my @chromium acct. Content is the
same.

[cfredric, 2016-11-04 19:12:29]

The CQ bit was checked by cfredric@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 19:13:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-11-04 19:18:53]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org, yoav@yoav.ws

[Charlie Harrison, 2016-11-04 19:18:53]

LGTM! Let's +Yoav for another look and non parser owners.

Note this was migrated from https://codereview.chromium.org/2473113002/

[commit-bot: I haz the power, 2016-11-04 20:50:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 20:50:09]

Dry run: This issue passed the CQ dry run.

[cfredric, 2016-11-08 15:25:39]

@yoav: Could you please take a look at this? Thanks!

[Charlie Harrison, 2016-11-10 14:09:46]

Yoav: friendly ping as we're trying to get this landed before branch cut.

[Yoav Weiss, 2016-11-10 14:21:16]

Apologies for the delay (travel...)

LGTM % question regarding the counters. I wonder if we should keep the counter
(and add the counting logic to HTMLPreloadScanner:shouldPreload()) so that we'd
know the trends of such content

https://codereview.chromium.org/2479703003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.h (left):

https://codereview.chromium.org/2479703003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.h:1278:
ScriptInvalidTypeOrLanguage = 1557,
Should we continue to count this, just in case?

[Charlie Harrison, 2016-11-10 14:55:34]

Hm... I didn't think UseCounter is threadsafe, is it?

[Yoav Weiss, 2016-11-10 15:09:38]

On 2016/11/10 14:55:34, Charlie Harrison wrote:
> Hm... I didn't think UseCounter is threadsafe, is it?

Oh no. It's really not... My bad.

In that case, continuing to count this is probably not worth the extra
complexity.

LGTM. Ship it! :)

[cfredric, 2016-11-10 15:18:27]

The CQ bit was checked by cfredric@chromium.org

[commit-bot: I haz the power, 2016-11-10 15:18:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 17:02:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-10 17:04:11]

Description was changed from

==========
Stop preloading scripts that have invalid type/language attributes

This patch removes prefetching of scripts that have invalid type/language
attributes, and removes the deprecation warning. This also adds/edits tests
accordingly.

BUG=626321
==========

to

==========
Stop preloading scripts that have invalid type/language attributes

This patch removes prefetching of scripts that have invalid type/language
attributes, and removes the deprecation warning. This also adds/edits tests
accordingly.

BUG=626321

Committed: https://crrev.com/f76c6bc7e8fa6e1ca60101ab3dfc35ba7a40594c
Cr-Commit-Position: refs/heads/master@{#431277}
==========

[commit-bot: I haz the power, 2016-11-10 17:04:12]

Patchset 1 (id:??) landed as
https://crrev.com/f76c6bc7e8fa6e1ca60101ab3dfc35ba7a40594c
Cr-Commit-Position: refs/heads/master@{#431277}