Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2479683004: base: Cleanup class/struct forward declarations (Closed)

Created:
4 years, 1 month ago by jbriance
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sadrul, tfarina, robliao+watch_chromium.org, gavinp+memory_chromium.org, wfh+watch_chromium.org, fdoray+watch_chromium.org, asvitkine+watch_chromium.org, mac-reviews_chromium.org, tracing+reviews_chromium.org, gab+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in base header files. BUG=662195 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/9348cd6059f26722b49ff7fe784631b71f05b8c6 Cr-Commit-Position: refs/heads/master@{#430160}

Patch Set 1 #

Patch Set 2 : Add missing forward declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -40 lines) Patch
M base/android/java_handler_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/android/java_message_handler_factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/debug/activity_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/files/file_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/files/important_file_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/mac/bundle_locations.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/shared_memory_handle.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/message_loop/incoming_task_queue.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/metrics/histogram.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/metrics/histogram_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/metrics/persistent_histogram_allocator.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/metrics/persistent_sample_map.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/metrics/statistics_recorder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/synchronization/waitable_event_watcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/task_scheduler/task_scheduler_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/task_scheduler/test_task_factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/test/launcher/test_launcher.h View 1 chunk +0 lines, -5 lines 0 comments Download
M base/third_party/libevent/http-internal.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/threading/worker_pool.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/threading/worker_pool_posix.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/trace_event/memory_allocator_dump.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event/process_memory_dump.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event/trace_event_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_synthetic_delay.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/trace_event/trace_log.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_raster_source.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
jbriance
4 years, 1 month ago (2016-11-04 14:43:15 UTC) #3
Nico
lgtm
4 years, 1 month ago (2016-11-04 16:09:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479683004/1
4 years, 1 month ago (2016-11-04 16:16:56 UTC) #6
jbriance
+ enne, danakj and vmpstr for cc/test/fake_raster_source.h change
4 years, 1 month ago (2016-11-04 16:23:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/297353)
4 years, 1 month ago (2016-11-04 16:25:50 UTC) #10
piman
cc lgtm
4 years, 1 month ago (2016-11-04 20:23:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479683004/20001
4 years, 1 month ago (2016-11-04 20:25:26 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/174788)
4 years, 1 month ago (2016-11-04 23:05:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479683004/20001
4 years, 1 month ago (2016-11-05 08:34:22 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-05 09:36:32 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 09:39:16 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9348cd6059f26722b49ff7fe784631b71f05b8c6
Cr-Commit-Position: refs/heads/master@{#430160}

Powered by Google App Engine
This is Rietveld 408576698