Use the new argument ordering for mx_cprng_draw

Use the new argument ordering for mx_cprng_draw

BUG=
R=abarth@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/1e4092f5a8d0466ea29136985a1cb0be11e1dac0

[abarth, 2016-11-03 22:00:31]

https://codereview.chromium.org/2479683002/diff/1/runtime/bin/crypto_fuchsia.cc
File runtime/bin/crypto_fuchsia.cc (right):

https://codereview.chromium.org/2479683002/diff/1/runtime/bin/crypto_fuchsia....
runtime/bin/crypto_fuchsia.cc:22: mx_size_t res;
I'd zero-initial because I'm paranoid.  Is ERR_INVALID_ARGS really the only
error that can cause this value not to be assigned?

[abarth, 2016-11-03 22:00:33]

lgtm

[kulakowski1, 2016-11-03 22:08:56]

kulakowski@google.com changed reviewers:
+ kulakowski@google.com

[kulakowski1, 2016-11-03 22:08:56]

https://codereview.chromium.org/2479683002/diff/1/runtime/bin/crypto_fuchsia.cc
File runtime/bin/crypto_fuchsia.cc (right):

https://codereview.chromium.org/2479683002/diff/1/runtime/bin/crypto_fuchsia....
runtime/bin/crypto_fuchsia.cc:22: mx_size_t res;
On 2016/11/03 22:00:31, abarth wrote:
> I'd zero-initial because I'm paranoid.  Is ERR_INVALID_ARGS really the only
> error that can cause this value not to be assigned?

Done.

[abarth-chromium, 2016-11-03 22:09:57]

Description was changed from

==========
Use the new argument ordering for mx_cprng_draw

BUG=
R=zra@google.com, abarth@google.com
==========

to

==========
Use the new argument ordering for mx_cprng_draw

BUG=
R=abarth@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1e4092f5a8d0466ea29136985a1cb0be11e1dac0
==========

[abarth-chromium, 2016-11-03 22:09:58]

Committed patchset #2 (id:20001) manually as
1e4092f5a8d0466ea29136985a1cb0be11e1dac0 (presubmit successful).

[azani_google, 2016-11-03 22:36:28]

On 2016/11/03 22:09:58, abarth-chromium wrote:
> Committed patchset #2 (id:20001) manually as
> 1e4092f5a8d0466ea29136985a1cb0be11e1dac0 (presubmit successful).

I'm getting this error which looks like it might be related to this CL:

FAILED: obj/dart/runtime/bin/standalone_dart_io.crypto_fuchsia.o 
/usr/local/google/home/azani/goma/gomacc
../../buildtools/toolchain/clang+llvm-x86_64-linux/bin/clang++ -MMD -MF
obj/dart/runtime/bin/standalone_dart_io.crypto_fuchsia.o.d
-DDART_IO_SECURE_SOCKET_DISABLED
-DSYSROOT_VERSION=918aa1c30cc6615ce59e0b71b164f48c1f9b1f5f -DNDEBUG
-I../../dart/runtime -I../../third_party -I../.. -Igen -g
--sysroot=../sysroot/x86_64-fuchsia --target=x86_64-fuchsia -Werror -Wall
-Wextra -Wno-unused-parameter -g -O0 -Werror -Wall -Wextra -Wno-unused-parameter
-Wnon-virtual-dtor -Wvla -Wno-conversion-null -Woverloaded-virtual -g3 -ggdb3
-fno-rtti -fno-exceptions -O3 -fvisibility-inlines-hidden -std=c++14
-fno-exceptions -fno-rtti -c ../../dart/runtime/bin/crypto_fuchsia.cc -o
obj/dart/runtime/bin/standalone_dart_io.crypto_fuchsia.o
../../dart/runtime/bin/crypto_fuchsia.cc:22:28: error: no matching function for
call to 'mx_cprng_draw'
    const mx_ssize_t res = mx_cprng_draw(buffer + read, len);
                           ^~~~~~~~~~~~~
../sysroot/x86_64-fuchsia/include/magenta/syscalls.inc:154:1: note: candidate
function not viable: requires 3 arguments, but 2 were provided
MAGENTA_SYSCALL_DEF(3, 3, 160, mx_status_t, cprng_draw, USER_PTR(void) buffer,
mx_size_t len,
^
../sysroot/x86_64-fuchsia/include/magenta/syscalls.h:16:16: note: expanded from
macro 'MAGENTA_SYSCALL_DEF'
    extern ret mx_##name(args);
               ^
<scratch space>:277:1: note: expanded from here
mx_cprng_draw
^
1 error generated.

[kulakowski1, 2016-11-03 22:37:39]

On 2016/11/03 22:36:28, azani_google wrote:
> On 2016/11/03 22:09:58, abarth-chromium wrote:
> > Committed patchset #2 (id:20001) manually as
> > 1e4092f5a8d0466ea29136985a1cb0be11e1dac0 (presubmit successful).
> 
> I'm getting this error which looks like it might be related to this CL:
> 
> FAILED: obj/dart/runtime/bin/standalone_dart_io.crypto_fuchsia.o 
> /usr/local/google/home/azani/goma/gomacc
> ../../buildtools/toolchain/clang+llvm-x86_64-linux/bin/clang++ -MMD -MF
> obj/dart/runtime/bin/standalone_dart_io.crypto_fuchsia.o.d
> -DDART_IO_SECURE_SOCKET_DISABLED
> -DSYSROOT_VERSION=918aa1c30cc6615ce59e0b71b164f48c1f9b1f5f -DNDEBUG
> -I../../dart/runtime -I../../third_party -I../.. -Igen -g
> --sysroot=../sysroot/x86_64-fuchsia --target=x86_64-fuchsia -Werror -Wall
> -Wextra -Wno-unused-parameter -g -O0 -Werror -Wall -Wextra
-Wno-unused-parameter
> -Wnon-virtual-dtor -Wvla -Wno-conversion-null -Woverloaded-virtual -g3 -ggdb3
> -fno-rtti -fno-exceptions -O3 -fvisibility-inlines-hidden -std=c++14
> -fno-exceptions -fno-rtti -c ../../dart/runtime/bin/crypto_fuchsia.cc -o
> obj/dart/runtime/bin/standalone_dart_io.crypto_fuchsia.o
> ../../dart/runtime/bin/crypto_fuchsia.cc:22:28: error: no matching function
for
> call to 'mx_cprng_draw'
>     const mx_ssize_t res = mx_cprng_draw(buffer + read, len);
>                            ^~~~~~~~~~~~~
> ../sysroot/x86_64-fuchsia/include/magenta/syscalls.inc:154:1: note: candidate
> function not viable: requires 3 arguments, but 2 were provided
> MAGENTA_SYSCALL_DEF(3, 3, 160, mx_status_t, cprng_draw, USER_PTR(void) buffer,
> mx_size_t len,
> ^
> ../sysroot/x86_64-fuchsia/include/magenta/syscalls.h:16:16: note: expanded
from
> macro 'MAGENTA_SYSCALL_DEF'
>     extern ret mx_##name(args);
>                ^
> <scratch space>:277:1: note: expanded from here
> mx_cprng_draw
> ^
> 1 error generated.

This CL fixes that issue.