Move compositor InputHandler from RenderViewImpl to RenderWidget.

third_party/WebKit/Source/web/tests/WebViewTest.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 3335 matching lines @@
       WebString::fromUTF8(m_baseURL.c_str()),
       WebString::fromUTF8("add_frame_in_unload.html"));
   m_webViewHelper.initializeAndLoad(
       m_baseURL + "add_frame_in_unload_wrapper.html", true, &frameClient);
   FrameTestHelpers::loadFrame(m_webViewHelper.webView()->mainFrame(),
                               "about:blank");
   EXPECT_EQ(1, frameClient.count());
   m_webViewHelper.reset();
 }
 
-class TouchEventHandlerWebViewClient
-    : public FrameTestHelpers::TestWebViewClient {
+class TouchEventHandlerWebWidgetClient
+    : public FrameTestHelpers::TestWebWidgetClient {
  public:
   // WebWidgetClient methods
   void hasTouchEventHandlers(bool state) override {
     m_hasTouchEventHandlerCount[state]++;
   }
 
   // Local methods
-  TouchEventHandlerWebViewClient() : m_hasTouchEventHandlerCount() {}
+  TouchEventHandlerWebWidgetClient() : m_hasTouchEventHandlerCount() {}
 
   int getAndResetHasTouchEventHandlerCallCount(bool state) {
     int value = m_hasTouchEventHandlerCount[state];
     m_hasTouchEventHandlerCount[state] = 0;
     return value;
   }
 
  private:
   int m_hasTouchEventHandlerCount[2];
 };
 
 // This test verifies that WebWidgetClient::hasTouchEventHandlers is called
 // accordingly for various calls to EventHandlerRegistry::did{Add|Remove|
 // RemoveAll}EventHandler(..., TouchEvent). Verifying that those calls are made
 // correctly is the job of LayoutTests/fast/events/event-handler-count.html.
 TEST_P(WebViewTest, HasTouchEventHandlers) {
-  TouchEventHandlerWebViewClient client;
+  TouchEventHandlerWebWidgetClient client;
+  // We need to create a LayerTreeView for the client before loading the page,
+  // otherwise ChromeClient will default to assuming there are touch handlers.
+  WebLayerTreeView* layerTreeView = client.initializeLayerTreeView();
   std::string url = m_baseURL + "has_touch_event_handlers.html";
   URLTestHelpers::registerMockedURLLoad(toKURL(url),
                                         "has_touch_event_handlers.html");
   WebViewImpl* webViewImpl =
-      m_webViewHelper.initializeAndLoad(url, true, 0, &client);
+      m_webViewHelper.initializeAndLoad(url, true, 0, 0, &client);
+  DCHECK(layerTreeView);

[dcheng, 2017/01/16 11:05:41]

Nit: Prefer ASSERT in tests

[wjmaclean, 2017/01/17 18:23:28]

Presubmit complains ASSERT is deprecated.

[dcheng, 2017/01/18 00:13:03]

To be precise, ASSERT_TRUE. DCHECK() will get skipped in a release build without
dchecks, while ASSERT_TRUE will still be checked (and handled gracefully by
gtest)

[wjmaclean, 2017/01/18 14:01:23]

Ooops, sorry. I read your comment too literally for some reason. Fixed.

   const EventHandlerRegistry::EventHandlerClass touchEvent =
       EventHandlerRegistry::TouchStartOrMoveEventBlocking;
 
   // The page is initialized with at least one no-handlers call.
   // In practice we get two such calls because WebViewHelper::initializeAndLoad
-  // first initializes and empty frame, and then loads a document into it, so
+  // first initializes an empty frame, and then loads a document into it, so
   // there are two FrameLoader::commitProvisionalLoad calls.
-  EXPECT_GE(client.getAndResetHasTouchEventHandlerCallCount(false), 1);
+  EXPECT_LT(0, client.getAndResetHasTouchEventHandlerCallCount(false));
   EXPECT_EQ(0, client.getAndResetHasTouchEventHandlerCallCount(true));
 
   // Adding the first document handler results in a has-handlers call.
   Document* document = webViewImpl->mainFrameImpl()->frame()->document();
   EventHandlerRegistry* registry =
       &document->frameHost()->eventHandlerRegistry();
   registry->didAddEventHandler(*document, touchEvent);
   EXPECT_EQ(0, client.getAndResetHasTouchEventHandlerCallCount(false));
   EXPECT_EQ(1, client.getAndResetHasTouchEventHandlerCallCount(true));
 
@@ skipping 946 matching lines @@
   frame->printBegin(printParams, WebNode());
   webView->resize(WebSize(500, 500));
   EXPECT_EQ(500, vwElement->offsetWidth());
 
   webView->resize(WebSize(800, 600));
   frame->printEnd();
   EXPECT_EQ(800, vwElement->offsetWidth());
 }
 
 }  // namespace blink