Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: components/update_client/utils.cc

Issue 2479633003: Makes the component installers return a Result instead of a bool. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/utils.h ('k') | extensions/browser/updater/update_install_shim.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/utils.cc
diff --git a/components/update_client/utils.cc b/components/update_client/utils.cc
index 39ab431a7b5e4488512913777b2385f97f17a940..967b7ba05b63211113628dd9561654f6645f5bee 100644
--- a/components/update_client/utils.cc
+++ b/components/update_client/utils.cc
@@ -12,6 +12,7 @@
#include <cstring>
#include <vector>
+#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/memory_mapped_file.h"
@@ -27,6 +28,7 @@
#include "components/update_client/configurator.h"
#include "components/update_client/crx_update_item.h"
#include "components/update_client/update_client.h"
+#include "components/update_client/update_client_errors.h"
#include "components/update_client/update_query_params.h"
#include "crypto/secure_hash.h"
#include "crypto/sha2.h"
@@ -310,4 +312,9 @@ void RemoveUnsecureUrls(std::vector<GURL>* urls) {
urls->end());
}
+CrxInstaller::Result InstallFunctionWrapper(base::Callback<bool()> callback) {
+ return CrxInstaller::Result(callback.Run() ? InstallError::NONE
+ : InstallError::GENERIC_ERROR);
+}
+
} // namespace update_client
« no previous file with comments | « components/update_client/utils.h ('k') | extensions/browser/updater/update_install_shim.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698