chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc - Issue 2479633003: Makes the component installers return a Result instead of a bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

Issue 2479633003: Makes the component installers return a Result instead of a bool. (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/supervised_user_whitelist_installer.cc ('k') | chrome/browser/component_updater/sw_reporter_installer_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

diff --git a/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc b/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

index 783df2b2f8db7fbda2cc3170285d5f01579b3fff..e1f0eb273feed97ad0613814cf71b298bd17812b 100644

--- a/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

+++ b/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

@@ -351,7 +351,9 @@ TEST_F(SupervisedUserWhitelistInstallerTest, InstallNewWhitelist) {

const CrxComponent* component =

component_update_service_.registered_component();

ASSERT_TRUE(component);

- EXPECT_TRUE(component->installer->Install(manifest_, unpacked_path));

+ const auto result = component->installer->Install(manifest_, unpacked_path);

+ EXPECT_EQ(0, result.error);

+ EXPECT_EQ(0, result.extended_error);

observer.Wait();

EXPECT_EQ(whitelist_path_.value(), observer.whitelist_path().value());