chrome/browser/component_updater/origin_trials_component_installer.h - Issue 2479633003: Makes the component installers return a Result instead of a bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/origin_trials_component_installer.h

Issue 2479633003: Makes the component installers return a Result instead of a bool. (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/file_type_policies_component_installer.cc ('k') | chrome/browser/component_updater/origin_trials_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/origin_trials_component_installer.h

diff --git a/chrome/browser/component_updater/origin_trials_component_installer.h b/chrome/browser/component_updater/origin_trials_component_installer.h

index aad6cac5a77bf8c1b49b5fdf919d8a278e559651..7bc337b1414e88bfc96c04185296c58c4dff1ceb 100644

--- a/chrome/browser/component_updater/origin_trials_component_installer.h

+++ b/chrome/browser/component_updater/origin_trials_component_installer.h

@@ -31,8 +31,9 @@ class OriginTrialsComponentInstallerTraits : public ComponentInstallerTraits {

const base::FilePath& install_dir) const override;

bool SupportsGroupPolicyEnabledComponentUpdates() const override;

bool RequiresNetworkEncryption() const override;

- bool OnCustomInstall(const base::DictionaryValue& manifest,

- const base::FilePath& install_dir) override;

+ update_client::CrxInstaller::Result OnCustomInstall(

+ const base::DictionaryValue& manifest,

+ const base::FilePath& install_dir) override;

void ComponentReady(const base::Version& version,

const base::FilePath& install_dir,

std::unique_ptr<base::DictionaryValue> manifest) override;