Makes the component installers return a Result instead of a bool.

components/update_client/update_client_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_path.h"
@@ skipping 1257 matching lines @@
   update_client->RemoveObserver(&observer);
 }
 
 // Tests the update scenario for one CRX where the CRX installer returns
 // an error.
 TEST_F(UpdateClientTest, OneCrxInstallError) {
   class MockInstaller : public CrxInstaller {
    public:
     MOCK_METHOD1(OnUpdateError, void(int error));
     MOCK_METHOD2(Install,
-                 bool(const base::DictionaryValue& manifest,
-                      const base::FilePath& unpack_path));
+                 Result(const base::DictionaryValue& manifest,
+                        const base::FilePath& unpack_path));
     MOCK_METHOD2(GetInstalledFile,
                  bool(const std::string& file, base::FilePath* installed_file));
     MOCK_METHOD0(Uninstall, bool());
 
     static void OnInstall(const base::DictionaryValue& manifest,
                           const base::FilePath& unpack_path) {
       base::DeleteFile(unpack_path, true);
     }
 
    protected:
     ~MockInstaller() override {}
   };
 
   class DataCallbackFake {
    public:
     static void Callback(const std::vector<std::string>& ids,
                          std::vector<CrxComponent>* components) {
       scoped_refptr<MockInstaller> installer(new MockInstaller());
 
       EXPECT_CALL(*installer, OnUpdateError(_)).Times(0);
       EXPECT_CALL(*installer, Install(_, _))
-          .WillOnce(DoAll(Invoke(MockInstaller::OnInstall), Return(false)));
+          .WillOnce(
+              DoAll(Invoke(MockInstaller::OnInstall),
+                    Return(CrxInstaller::Result(InstallError::GENERIC_ERROR))));
       EXPECT_CALL(*installer, GetInstalledFile(_, _)).Times(0);
       EXPECT_CALL(*installer, Uninstall()).Times(0);
 
       CrxComponent crx;
       crx.name = "test_jebg";
       crx.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));
       crx.version = base::Version("0.9");
       crx.installer = installer;
       components->push_back(crx);
     }
@@ skipping 1394 matching lines @@
   update_client->Update(
       ids, base::Bind(&DataCallbackFake::Callback),
       base::Bind(&CompletionCallbackFake::Callback, quit_closure()));
 
   RunThreads();
 
   update_client->RemoveObserver(&observer);
 }
 
 }  // namespace update_client