Makes the component installers return a Result instead of a bool.

components/update_client/update_client_errors.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UPDATE_CLIENT_UPDATE_CLIENT_ERRORS_H_
 #define COMPONENTS_UPDATE_CLIENT_UPDATE_CLIENT_ERRORS_H_
 
 namespace update_client {
 
 // Errors generated as a result of calling UpdateClient member functions.
@@ skipping 23 matching lines @@
 // the Chrome net stack.
 enum class CrxDownloaderError {
   NONE = 0,
   NO_URL = 10,
   NO_HASH = 11,
   BAD_HASH = 12,  // The downloaded file fails the hash verification.
   GENERIC_ERROR = -1
 };
 
 // These errors are returned with the |kUnpackError| error category and
-// indicate unpacker, patcher, or install errors.
+// indicate unpacker or patcher error.
 enum class UnpackerError {
   kNone = 0,
-  kInvalidParams,
-  kInvalidFile,
-  kUnzipPathError,
-  kUnzipFailed,
-  kNoManifest,
-  kBadManifest,
-  kBadExtension,
-  kInvalidId,
-  kInstallerError,
-  kIoError,
-  kDeltaVerificationFailure,
-  kDeltaBadCommands,
-  kDeltaUnsupportedCommand,
-  kDeltaOperationFailure,
-  kDeltaPatchProcessFailure,
-  kDeltaMissingExistingFile,
-  kFingerprintWriteFailed,
+  kInvalidParams = 1,
+  kInvalidFile = 2,
+  kUnzipPathError = 3,
+  kUnzipFailed = 4,
+  // kNoManifest = 5,         // Deprecated. Never used.
+  kBadManifest = 6,
+  kBadExtension = 7,
+  kInvalidId = 8,
+  // kInstallerError = 9,     // Deprecated. Don't use.
+  kIoError = 10,
+  kDeltaVerificationFailure = 11,
+  kDeltaBadCommands = 12,
+  kDeltaUnsupportedCommand = 13,
+  kDeltaOperationFailure = 14,
+  kDeltaPatchProcessFailure = 15,
+  kDeltaMissingExistingFile = 16,
+  // kFingerprintWriteFailed = 17,    // Deprecated. Don't use.
 };
 
 // These errors are returned with the |kServiceError| error category and
+// are returned by the component installers.
+enum class InstallError {
+  NONE = 0,
+  FINGERPRINT_WRITE_FAILED = 2,
+  BAD_MANIFEST = 3,
+  GENERIC_ERROR = 9,        // Matches kInstallerError for compatibility.
+  CUSTOM_ERROR_BASE = 100,  // Specific installer errors go above this value.
+};
+
+// These errors are returned with the |kInstallError| error category and
 // indicate critical or configuration errors in the update service.
 enum class ServiceError {
   NONE = 0,
   SERVICE_WAIT_FAILED = 1,
   UPDATE_DISABLED = 2,
 };
 
 }  // namespace update_client
 
 #endif  // COMPONENTS_UPDATE_CLIENT_UPDATE_CLIENT_ERRORS_H_