Makes the component installers return a Result instead of a bool.

components/update_client/update_client.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UPDATE_CLIENT_UPDATE_CLIENT_H_
 #define COMPONENTS_UPDATE_CLIENT_UPDATE_CLIENT_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "base/version.h"
+#include "components/update_client/update_client_errors.h"
 
 // The UpdateClient class is a facade with a simple interface. The interface
 // exposes a few APIs to install a CRX or update a group of CRXs.
 //
 // The difference between a CRX install and a CRX update is relatively minor.
 // The terminology going forward will use the word "update" to cover both
 // install and update scenarios, except where details regarding the install
 // case are relevant.
 //
 // Handling an update consists of a series of actions such as sending an update
@@ skipping 114 matching lines @@
 class Configurator;
 enum class Error;
 struct CrxUpdateItem;
 
 // Called when a non-blocking call in this module completes.
 using Callback = base::Callback<void(Error error)>;
 
 // Defines an interface for a generic CRX installer.
 class CrxInstaller : public base::RefCountedThreadSafe<CrxInstaller> {
  public:
+  // Contains the result of the Install operation.
+  struct Result {
+    explicit Result(int error, int extended_error = 0)
+        : error(error), extended_error(extended_error) {}
+    explicit Result(InstallError error, int extended_error = 0)
+        : error(static_cast<int>(error)), extended_error(extended_error) {}
+    int error = 0;  // 0 indicates that install has been successful.
+    int extended_error = 0;
+  };
+
   // Called on the main thread when there was a problem unpacking or
   // verifying the CRX. |error| is a non-zero value which is only meaningful
   // to the caller.
   virtual void OnUpdateError(int error) = 0;
 
   // Called by the update service when a CRX has been unpacked
   // and it is ready to be installed. |manifest| contains the CRX manifest
   // as a json dictionary.|unpack_path| contains the temporary directory
   // with all the unpacked CRX files.
   // This method may be called from a thread other than the main thread.
-  virtual bool Install(const base::DictionaryValue& manifest,
-                       const base::FilePath& unpack_path) = 0;
+  virtual Result Install(const base::DictionaryValue& manifest,
+                         const base::FilePath& unpack_path) = 0;
 
   // Sets |installed_file| to the full path to the installed |file|. |file| is
   // the filename of the file in this CRX. Returns false if this is
   // not possible (the file has been removed or modified, or its current
   // location is unknown). Otherwise, it returns true.
   virtual bool GetInstalledFile(const std::string& file,
                                 base::FilePath* installed_file) = 0;
 
   // Called when a CRX has been unregistered and all versions should
   // be uninstalled from disk. Returns true if uninstallation is supported,
@@ skipping 171 matching lines @@
 scoped_refptr<UpdateClient> UpdateClientFactory(
     const scoped_refptr<Configurator>& config);
 
 // This must be called prior to the construction of any Configurator that
 // contains a PrefService.
 void RegisterPrefs(PrefRegistrySimple* registry);
 
 }  // namespace update_client
 
 #endif  // COMPONENTS_UPDATE_CLIENT_UPDATE_CLIENT_H_