Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2479633002: Fix pipeline integration tests for seek / duration changes. (Closed)

Created:
4 years, 1 month ago by liberato (no reviews please)
Modified:
4 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix pipeline integration tests for seek / duration changes. PipelineIntegrationTestBase now exposes GetMediaDuration(), so that tests can seek to the start of the media, rather than assuming it to be zero. The ffmpeg_regression_tests would fail, previously, if the media's start time wasn't zero, since they would seek to 0 and then get mad that the media time was something else. Also, this permits the pipeline to notify the client about an indefinite duration, then notify it about a smaller one. This happens if the media duration isn't known initially, but then becomes known when the end of media is found. Previously, the second call to Pipeline::Client::OnDurationChanged would cause the integration test base to get mad. Added a test case to ffmpeg_regression_tests which hits both of these cases. BUG=662118 TEST=ffmpeg_regression_tests Committed: https://crrev.com/bc29809b850a2dcd2f803d4f25238085f64d7906 Cr-Commit-Position: refs/heads/master@{#429690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M media/ffmpeg/ffmpeg_regression_tests.cc View 2 chunks +5 lines, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.h View 2 chunks +6 lines, -0 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 3 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
liberato (no reviews please)
doesn't address the actual asan failure, but fixes the test harness a bit. will follow ...
4 years, 1 month ago (2016-11-03 18:56:56 UTC) #5
DaleCurtis
Nice fix, lgtm!
4 years, 1 month ago (2016-11-03 19:02:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479633002/1
4 years, 1 month ago (2016-11-03 20:39:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 20:45:38 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 20:48:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc29809b850a2dcd2f803d4f25238085f64d7906
Cr-Commit-Position: refs/heads/master@{#429690}

Powered by Google App Engine
This is Rietveld 408576698