Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2760)

Issue 2479603003: Revert of Adding new media controls to MediaNotification (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri (slow - plz ping), nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding new media controls to MediaNotification (patchset #10 id:200001 of https://codereview.chromium.org/2442303002/ ) Reason for revert: Speculative revert for webview apk test failures: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36922 Original issue's description: > Adding media controls to MediaNotification > > This CL adds new media controls to MediaNotification. The controls are enabled > from the MediaSession API in blink, and is propagated to the browser side > through mojom MediaSessionService. Then we show a corresponding button in media > notification. When the user clicks the button, the event will be propagate back > to the page through mojom MediaSessionClient. > > This CL has the following changes: > * Plumb media control messages from content/ to chrome/ Java. > * Add control buttons to MediaNotification > > Slides explaining how media controls work: > https://docs.google.com/a/google.com/presentation/d/1jGNB9aT3mbpPszC3SiQnQ70CjVDmH-haomHCrqSVVAw/edit?usp=sharing > > Test URL: > http://xxyzzzq.github.io/sandbox/media-session/full-test.html > > BUG=656563 > TEST=MANUAL > > Committed: https://crrev.com/fb90347c0ad1437e9fa674e7c70db9512b570444 > Cr-Commit-Position: refs/heads/master@{#429614} TBR=avayvod@chromium.org,boliu@chromium.org,jam@chromium.org,kenrb@chromium.org,tedchoc@chromium.org,zqzhang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=656563 Committed: https://crrev.com/744aa665b7e0d15b7c277283a5a1926e5d778085 Cr-Commit-Position: refs/heads/master@{#429697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -332 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/java/res/drawable-hdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/ic_media_control_skip_next.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/ic_media_control_skip_previous.png View Binary file 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSessionImpl.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java View 9 chunks +34 lines, -44 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationListener.java View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 9 chunks +1 line, -45 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 8 chunks +1 line, -37 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/media/session/media_session_android.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/media/session/media_session_android.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M content/browser/media/session/media_session_impl.h View 4 chunks +0 lines, -21 lines 0 comments Download
M content/browser/media/session/media_session_impl.cc View 4 chunks +2 lines, -28 lines 0 comments Download
M content/browser/media/session/media_session_service_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/media/session/media_session_service_impl.cc View 2 chunks +10 lines, -29 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MediaSessionImpl.java View 3 chunks +0 lines, -20 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/MediaSession.java View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/MediaSessionObserver.java View 1 chunk +0 lines, -12 lines 0 comments Download
M content/public/browser/media_session.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/public/browser/media_session_observer.h View 2 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mathieu
Created Revert of Adding new media controls to MediaNotification
4 years, 1 month ago (2016-11-03 21:24:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479603003/1
4 years, 1 month ago (2016-11-03 21:25:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 21:26:31 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/744aa665b7e0d15b7c277283a5a1926e5d778085 Cr-Commit-Position: refs/heads/master@{#429697}
4 years, 1 month ago (2016-11-03 21:30:02 UTC) #7
Mathieu
4 years, 1 month ago (2016-11-04 01:44:10 UTC) #8
Message was sent while issue was closed.
On 2016/11/03 21:30:02, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/744aa665b7e0d15b7c277283a5a1926e5d778085
> Cr-Commit-Position: refs/heads/master@{#429697}

My speculative revert was wrong, I am very sorry. Please reland at your
convenience!

Powered by Google App Engine
This is Rietveld 408576698