Expose images to accessibility

Expose images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/32e424c9defb30fdf056cc48f1c90451f8c6c2a9
Cr-Commit-Position: refs/heads/master@{#430199}

[David Tseng, 2016-11-04 18:13:49]

Description was changed from

==========
Expose images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=
==========

to

==========
Expose images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-04 18:14:44]

Description was changed from

==========
Expose images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Expose almost all images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-04 18:14:44]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-11-04 18:19:44]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[David Tseng, 2016-11-04 18:20:04]

Description was changed from

==========
Expose almost all images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Expose images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-04 18:20:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-11-04 18:34:05]

lgtm

This sounds good to me

If there are some images we should ignore on desktop
platforms to better match other browsers, we can add
back some of the logic in browser_accessibility

[dmazzoni, 2016-11-04 18:36:07]

https://codereview.chromium.org/2479593007/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/common/dom_util.js (right):

https://codereview.chromium.org/2479593007/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/common/dom_util.js:926: text =
'alt';
i'm assuming this is debugging code?

https://codereview.chromium.org/2479593007/diff/1/testing/buildbot/chromium.l...
File testing/buildbot/chromium.linux.json (left):

https://codereview.chromium.org/2479593007/diff/1/testing/buildbot/chromium.l...
testing/buildbot/chromium.linux.json:2955: "--enable-browser-side-navigation"
I'm assuming these changes don't belong

[David Tseng, 2016-11-04 18:49:05]

On 2016/11/04 18:36:07, dmazzoni wrote:
>
https://codereview.chromium.org/2479593007/diff/1/chrome/browser/resources/ch...
> File chrome/browser/resources/chromeos/chromevox/common/dom_util.js (right):
> 
>
https://codereview.chromium.org/2479593007/diff/1/chrome/browser/resources/ch...
> chrome/browser/resources/chromeos/chromevox/common/dom_util.js:926: text =
> 'alt';
> i'm assuming this is debugging code?

Removed; thanks.
> 
>
https://codereview.chromium.org/2479593007/diff/1/testing/buildbot/chromium.l...
> File testing/buildbot/chromium.linux.json (left):
> 
>
https://codereview.chromium.org/2479593007/diff/1/testing/buildbot/chromium.l...
> testing/buildbot/chromium.linux.json:2955: "--enable-browser-side-navigation"
> I'm assuming these changes don't belong

Bad rebase. Removed.

[David Tseng, 2016-11-04 18:49:12]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-04 18:49:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593007/#ps20001
(title: "Cleanup")

[commit-bot: I haz the power, 2016-11-04 18:49:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 19:24:17]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[David Tseng, 2016-11-05 07:00:48]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 07:00:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-11-05 07:05:48]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 07:05:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 08:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 08:16:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[David Tseng, 2016-11-06 06:39:23]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-06 06:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 07:50:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 07:50:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-11-06 17:48:29]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-06 17:48:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593007/#ps80001
(title: "Blink test fixes")

[commit-bot: I haz the power, 2016-11-06 17:48:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 19:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 19:20:37]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[David Tseng, 2016-11-06 20:04:51]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-06 20:04:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593007/#ps100001
(title: "A few more tests rebaselined.")

[commit-bot: I haz the power, 2016-11-06 20:05:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 22:07:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 22:07:46]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-11-06 22:14:45]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-11-06 22:14:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 23:32:59]

Description was changed from

==========
Expose images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Expose images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-06 23:33:00]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-06 23:36:34]

Description was changed from

==========
Expose images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Expose images to accessibility

Blink has some loose heuristics to ignore images, even ones that are important
for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey
information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent
determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/32e424c9defb30fdf056cc48f1c90451f8c6c2a9
Cr-Commit-Position: refs/heads/master@{#430199}
==========

[commit-bot: I haz the power, 2016-11-06 23:36:35]

Patchset 6 (id:??) landed as
https://crrev.com/32e424c9defb30fdf056cc48f1c90451f8c6c2a9
Cr-Commit-Position: refs/heads/master@{#430199}