Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2479593004: GCM Registration: rename RESPONSE_PARSING_FAILED to NO_RESPONSE_BODY (Closed)

Created:
4 years, 1 month ago by johnme
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

GCM Registration: rename RESPONSE_PARSING_FAILED to NO_RESPONSE_BODY The RegistrationRequest::RESPONSE_PARSING_FAILED enum value was confusingly named, since it is actually logged only when there is no body at all, not when parsing the body fails. Hence I'm renaming it to NO_RESPONSE_BODY to match UnregistrationRequest::NO_RESPONSE_BODY. BUG=none Review-Url: https://chromiumcodereview.appspot.com/2433083003 Cr-Commit-Position: refs/heads/master@{#426608} (cherry picked from commit f5ee18de1b2485a50255ab83968518b05ea2f359) Committed: https://chromium.googlesource.com/chromium/src/+/e9a8fe09ec516334c759e9e1a952a98b797926fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/gcm_driver/gcm_stats_recorder_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/registration_request.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/registration_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
johnme
4 years, 1 month ago (2016-11-03 17:53:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e9a8fe09ec516334c759e9e1a952a98b797926fa.

Powered by Google App Engine
This is Rietveld 408576698