Tracing: Bail out early in tracing tests when tracing is already enabled.

Tracing: Bail out early in tracing tests when tracing is already enabled.

Following up https://crrev.com/2479563002 .

BUG=657628, 656729
Committed: https://crrev.com/f98f6a4df243fd2bff7f2c0dfb919a0717f9a511
Cr-Commit-Position: refs/heads/master@{#431291}

[kraynov, 2016-11-03 16:07:59]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 16:08:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kraynov, 2016-11-03 16:08:55]

kraynov@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-11-03 16:13:59]

Only one comment.

https://codereview.chromium.org/2479593002/diff/1/components/tracing/child/ch...
File components/tracing/child/child_trace_message_filter_browsertest.cc (right):

https://codereview.chromium.org/2479593002/diff/1/components/tracing/child/ch...
components/tracing/child/child_trace_message_filter_browsertest.cc:182:
TEST_F(ChildTracingTest, EnableAndDisableTracing) {
what is the purpose if this TEST_F ? This should be already caught by the other
test_f in here.

[commit-bot: I haz the power, 2016-11-03 16:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 16:49:23]

Dry run: This issue passed the CQ dry run.

[kraynov, 2016-11-04 16:30:59]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[kraynov, 2016-11-04 16:31:41]

updated

[commit-bot: I haz the power, 2016-11-04 16:32:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kraynov, 2016-11-04 16:34:18]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 16:34:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 16:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 16:44:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kraynov, 2016-11-04 16:58:35]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 16:59:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 17:18:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kraynov, 2016-11-07 16:37:11]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 16:37:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 17:00:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 17:00:17]

Dry run: This issue passed the CQ dry run.

[kraynov, 2016-11-10 15:55:13]

kraynov@chromium.org changed reviewers:
+ perezju@chromium.org

[kraynov, 2016-11-10 15:55:14]

Please review, thanks

[Primiano Tucci (use gerrit), 2016-11-10 16:12:04]

LGTM with some comments

https://codereview.chromium.org/2479593002/diff/100001/components/tracing/chi...
File components/tracing/child/child_trace_message_filter_browsertest.cc (right):

https://codereview.chromium.org/2479593002/diff/100001/components/tracing/chi...
components/tracing/child/child_trace_message_filter_browsertest.cc:123:
"/data/local/chrome-trace-config.json")))) {
Please remove the check on the actual file. This path is going to change soon
and is not going to be fixed.
Just a check on IsEnabled should be enough.
I'd remove the OS_ANDROID check and just mix the message below.

https://codereview.chromium.org/2479593002/diff/100001/components/tracing/chi...
components/tracing/child/child_trace_message_filter_browsertest.cc:129: FAIL()
<< "Tracing has been already enabled. Very likely this is "
Oh actually I like FAIL() more.
DO you mind changing also the code I recently introduced in
memory_tracing_browsertest.cc and putting a FAIL (instead of the CHECK) also
there?

[kraynov, 2016-11-10 16:33:17]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 16:33:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 17:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 17:49:08]

Dry run: This issue passed the CQ dry run.

[kraynov, 2016-11-10 18:08:12]

The CQ bit was checked by kraynov@chromium.org

[kraynov, 2016-11-10 18:08:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593002/#ps120001
(title: "wording")

[commit-bot: I haz the power, 2016-11-10 18:08:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 18:14:30]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-10 18:38:39]

Description was changed from

==========
Tracing: Bail out early in tracing tests when tracing is already enabled.

Following up https://crrev.com/2479563002 .

BUG=657628, 656729
==========

to

==========
Tracing: Bail out early in tracing tests when tracing is already enabled.

Following up https://crrev.com/2479563002 .

BUG=657628, 656729

Committed: https://crrev.com/f98f6a4df243fd2bff7f2c0dfb919a0717f9a511
Cr-Commit-Position: refs/heads/master@{#431291}
==========

[commit-bot: I haz the power, 2016-11-10 18:38:40]

Patchset 7 (id:??) landed as
https://crrev.com/f98f6a4df243fd2bff7f2c0dfb919a0717f9a511
Cr-Commit-Position: refs/heads/master@{#431291}