third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp - Issue 2479563005: Create manager to track OffscreenCanvasSurfaceImpl instances

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

Issue 2479563005: Create manager to track OffscreenCanvasSurfaceImpl instances (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/offscreen_canvas_surface_manager.cc ('K') | « third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp ('k') | third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h » ('j') | third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

index 545ff92643d9ba89294cbe8cd24faa338584e502..4cd92072db75c48fb969437e0d2fc24aa0d98f53 100644

--- a/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

+++ b/third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModuleTest.cpp

@@ -43,7 +43,7 @@ OffscreenCanvas* HTMLCanvasElementModuleTest::transferControlToOffscreen(

// exclude the part that creates surface layer bridge because a mojo message

// pipe cannot be tested using webkit unit tests.

return HTMLCanvasElementModule::transferControlToOffscreenInternal(

- canvasElement(), exceptionState);

+ canvasElement(), DOMNodeIds::idForNode(&canvasElement()), exceptionState);

}

TEST_F(HTMLCanvasElementModuleTest, TransferControlToOffscreen) {