Create manager to track OffscreenCanvasSurfaceImpl instances

content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.h"
 
 #include "cc/surfaces/surface.h"
 #include "cc/surfaces/surface_manager.h"
 #include "content/browser/compositor/surface_utils.h"
+#include "content/browser/renderer_host/offscreen_canvas_surface_manager.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 
 namespace content {
 
 OffscreenCanvasCompositorFrameSink::OffscreenCanvasCompositorFrameSink(
     const cc::SurfaceId& surface_id,
     cc::mojom::MojoCompositorFrameSinkClientPtr client)
-    : surface_id_(surface_id), client_(std::move(client)) {
+    : surface_id_(surface_id), client_(std::move(client)), weak_factory_(this) {
   cc::SurfaceManager* manager = GetSurfaceManager();
   surface_factory_ = base::MakeUnique<cc::SurfaceFactory>(
       surface_id_.frame_sink_id(), manager, this);
   manager->RegisterFrameSinkId(surface_id_.frame_sink_id());
   surface_factory_->Create(surface_id_.local_frame_id());
+
+  DCHECK(OffscreenCanvasSurfaceManager::GetInstance()->GetSurfaceInstance(

[Fady Samuel, 2016/11/14 21:15:40]

Can we get rid of this?

[xlai (Olivia), 2016/11/15 17:16:18]

Done.

+      surface_id_.frame_sink_id()));

[dcheng, 2016/11/15 07:28:29]

Do we need to check somewhere higher in the stack that
OffscreenCanvasCompositorFrameSink is always created so it's paired with a valid
OffscreenSurface?

[xlai (Olivia), 2016/11/15 17:16:18]

I'm removing it now. I think this DCHECK is better to be placed in
the implementation of OffscreenCanvasSurfaceManager::OnSurfaceCreated
in a resizing workflow
but since I have not implemented that yet I'll delay doing
this.

 }
 
 OffscreenCanvasCompositorFrameSink::~OffscreenCanvasCompositorFrameSink() {
   cc::SurfaceManager* manager = GetSurfaceManager();
   if (!manager) {
     // Inform SurfaceFactory that SurfaceManager's no longer alive to
     // avoid its destruction error.
     surface_factory_->DidDestroySurfaceManager();
   } else {
     manager->InvalidateFrameSinkId(surface_id_.frame_sink_id());
@@ skipping 53 matching lines @@
   client_->DidReceiveCompositorFrameAck();
   DCHECK_GT(ack_pending_count_, 0);
   if (!surface_returned_resources_.empty()) {
     client_->ReclaimResources(surface_returned_resources_);
     surface_returned_resources_.clear();
   }
   ack_pending_count_--;
 }
 
 }  // namespace content