Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2479563003: [compiler] Delete extra map check in StringIterator. (Closed)

Created:
4 years, 1 month ago by Franzi
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Delete extra map check. Use HeapConstant for string_iterator_map rather than loading it manually. This avoids unnecessary map checks. BUG=v8:3822, v8:5267 Committed: https://crrev.com/0f7ea219f0e3927fa1d00a8ffdc38dbd74d7dbd7 Cr-Commit-Position: refs/heads/master@{#40741}

Patch Set 1 #

Patch Set 2 : Delete unnecessary variable. #

Patch Set 3 : Delete more unused variables. #

Total comments: 1

Patch Set 4 : Use native_context() in unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/compiler/js-builtin-reducer.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 27 (22 generated)
Franzi
PTAL. Thanks!
4 years, 1 month ago (2016-11-03 19:26:07 UTC) #14
Benedikt Meurer
LGTM once comment addressed. Thanks! https://codereview.chromium.org/2479563003/diff/40001/test/unittests/compiler/js-builtin-reducer-unittest.cc File test/unittests/compiler/js-builtin-reducer-unittest.cc (right): https://codereview.chromium.org/2479563003/diff/40001/test/unittests/compiler/js-builtin-reducer-unittest.cc#newcode39 test/unittests/compiler/js-builtin-reducer-unittest.cc:39: Handle<Context>()); You can just ...
4 years, 1 month ago (2016-11-03 19:43:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479563003/50001
4 years, 1 month ago (2016-11-03 21:22:04 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 1 month ago (2016-11-03 21:24:25 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:21:31 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0f7ea219f0e3927fa1d00a8ffdc38dbd74d7dbd7
Cr-Commit-Position: refs/heads/master@{#40741}

Powered by Google App Engine
This is Rietveld 408576698